Implement initial adapter tests on bigquery #142
Conversation
| from dbt.tests.adapter.basic.test_snapshot_timestamp import BaseSnapshotTimestamp | ||
|
|
||
| """ | ||
| Trying to create view `dbt-dev-168022`.`test16473926894805161392_test_basic`.`swappable`, |
There was a problem hiding this comment.
@jtcohen6 What is your take on how to avoid this error?
There was a problem hiding this comment.
@gshank This is a "good" error! And it doesn't look like we have any existing integration tests to confirm that this "good" error is raised in this case, so I'd also call this a "good" test case :)
I think we could take either/both of these approaches:
- xfail the standard test with this error message — it looks
- inherit + reimplement the standard test, adding in
--full-refresh, so that it can succeed
Maybe both, if that's straightforward enough to do?
gshank
force-pushed
the
ct-362-new_test_framework_bigquery
branch
from
85dd272
to
092b965
Compare
gshank
force-pushed
the
ct-362-new_test_framework_bigquery
branch
from
092b965
to
07b704e
Compare
|
|
||
|
|
||
| class TestSimpleMaterializationsBigQuery(BaseSimpleMaterializations): | ||
| # This test requires a full-refresh to replace a table with a view |
There was a problem hiding this comment.
Should we consider add this kind of logic to the dbt-core tests later on so that we don't need to do it anywhere in bigquery?
There was a problem hiding this comment.
The test_config sets a flag which does initiate different behavior in the dbt-core tests. I think we don't want to always do a full refresh in the adapter tests, because then we wouldn't ever be testing behavior without the full refresh, which ought to work for the other adapters.
resolves #135
Description
Initial implementation of tests ported from dbt-adapter-tests
Checklist
CHANGELOG.mdand added information about my change to the "dbt-bigquery next" section.