Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate to new framework for adapter testing during v1.1 upgrade #57

Closed
jtcohen6 opened this issue Apr 1, 2022 · 1 comment
Closed
Assignees

Comments

@jtcohen6
Copy link
Contributor

jtcohen6 commented Apr 1, 2022

Hey dbt-trino maintainers!

We've been developing a new framework for all integration/functional testing in dbt-core. One of our goals in the initiative has been to replace the suite of basic test cases for adapter plugins.

For now, the framework is comprised of:

  • Pytest utilities included in dbt-core==1.1.0b1
  • A set of "basic" test cases, at exact parity with the test cases built into the old .dbtspec / pytest-dbt-adapter

I have some draft docs (dbt-labs/docs.getdbt.com#1263) for using the new framework: https://deploy-preview-1263--docs-getdbt-com.netlify.app/docs/contributing/testing-a-new-adapter

It should be much easier to:

  • Override/reimplement test cases (as you've done here)
  • "Opt into" test cases for more-advanced functionality, which we'll be gradually adding into the same package of adapter-facing test cases
  • Add your own functional test cases for Trino-specific behavior, using the same built-in utilities, and reusing project fixtures if appropriate

If it proves helpful, you can also check out the way we've implemented the framework in some of our own adapter plugins:

Thanks for all the great work :)

@hovaesco
Copy link
Member

hovaesco commented May 5, 2022

Resolved by #65

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants