Skip to content

Commit

Permalink
Rm py36 tests, pkg metadata, bump reqs (#4223)
Browse files Browse the repository at this point in the history
  • Loading branch information
jtcohen6 committed Nov 8, 2021
1 parent 855419d commit 354c1e0
Show file tree
Hide file tree
Showing 7 changed files with 16 additions and 19 deletions.
2 changes: 1 addition & 1 deletion .github/scripts/integration-test-matrix.js
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
module.exports = ({ context }) => {
const defaultPythonVersion = "3.8";
const supportedPythonVersions = ["3.6", "3.7", "3.8", "3.9"];
const supportedPythonVersions = ["3.7", "3.8", "3.9"];
const supportedAdapters = ["postgres"];

// if PR, generate matrix based on files changed and PR labels
Expand Down
4 changes: 2 additions & 2 deletions .github/workflows/main.yml
Original file line number Diff line number Diff line change
Expand Up @@ -77,7 +77,7 @@ jobs:
strategy:
fail-fast: false
matrix:
python-version: [3.6, 3.7, 3.8] # TODO: support unit testing for python 3.9 (https://github.com/dbt-labs/dbt/issues/3689)
python-version: [3.7, 3.8] # TODO: support unit testing for python 3.9 (https://github.com/dbt-labs/dbt/issues/3689)

env:
TOXENV: "unit"
Expand Down Expand Up @@ -167,7 +167,7 @@ jobs:
fail-fast: false
matrix:
os: [ubuntu-latest, macos-latest, windows-latest]
python-version: [3.6, 3.7, 3.8, 3.9]
python-version: [3.7, 3.8, 3.9]

steps:
- name: Set up Python ${{ matrix.python-version }}
Expand Down
1 change: 1 addition & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -20,6 +20,7 @@
- Speed up node selection by skipping `incorporate_indirect_nodes` if not needed ([#4213](https://github.com/dbt-labs/dbt-core/issues/4213), [#4214](https://github.com/dbt-labs/dbt-core/issues/4214))
- When on_schema_change is set, pass common columns as dest_columns in incremental merge macros ([#4144](https://github.com/dbt-labs/dbt-core/issues/4144), [#4170](https://github.com/dbt-labs/dbt-core/pull/4170))
- Clear adapters before registering in lib module config generation ([#4218](https://github.com/dbt-labs/dbt-core/pull/4218))
- Remove official support for python 3.6, which is reaching end of life on December 23, 2021 ([#4134](https://github.com/dbt-labs/dbt-core/issues/4134), [#4223](https://github.com/dbt-labs/dbt-core/pull/4223))

Contributors:
- [@kadero](https://github.com/kadero) ([#3955](https://github.com/dbt-labs/dbt-core/pull/3955))
Expand Down
8 changes: 3 additions & 5 deletions core/setup.py
Original file line number Diff line number Diff line change
Expand Up @@ -2,9 +2,9 @@
import os
import sys

if sys.version_info < (3, 6):
if sys.version_info < (3, 7):
print('Error: dbt does not support this version of Python.')
print('Please upgrade to Python 3.6 or higher.')
print('Please upgrade to Python 3.7 or higher.')
sys.exit(1)


Expand Down Expand Up @@ -55,7 +55,6 @@
'agate>=1.6,<1.6.4',
'click>=8,<9',
'colorama>=0.3.9,<0.4.5',
'dataclasses>=0.6,<0.9;python_version<"3.7"',
'hologram==0.0.14',
'isodate>=0.6,<0.7',
'logbook>=1.5,<1.6',
Expand All @@ -82,10 +81,9 @@
'Operating System :: MacOS :: MacOS X',
'Operating System :: POSIX :: Linux',

'Programming Language :: Python :: 3.6',
'Programming Language :: Python :: 3.7',
'Programming Language :: Python :: 3.8',
'Programming Language :: Python :: 3.9',
],
python_requires=">=3.6.3",
python_requires=">=3.7",
)
7 changes: 3 additions & 4 deletions plugins/postgres/setup.py
Original file line number Diff line number Diff line change
Expand Up @@ -2,9 +2,9 @@
import os
import sys

if sys.version_info < (3, 6):
if sys.version_info < (3, 7):
print('Error: dbt does not support this version of Python.')
print('Please upgrade to Python 3.6 or higher.')
print('Please upgrade to Python 3.7 or higher.')
sys.exit(1)


Expand Down Expand Up @@ -82,10 +82,9 @@ def _dbt_psycopg2_name():
'Operating System :: MacOS :: MacOS X',
'Operating System :: POSIX :: Linux',

'Programming Language :: Python :: 3.6',
'Programming Language :: Python :: 3.7',
'Programming Language :: Python :: 3.8',
'Programming Language :: Python :: 3.9',
],
python_requires=">=3.6.2",
python_requires=">=3.7",
)
7 changes: 3 additions & 4 deletions setup.py
Original file line number Diff line number Diff line change
Expand Up @@ -14,9 +14,9 @@
sys.exit(1)


if sys.version_info < (3, 6):
if sys.version_info < (3, 7):
print('Error: dbt does not support this version of Python.')
print('Please upgrade to Python 3.6 or higher.')
print('Please upgrade to Python 3.7 or higher.')
sys.exit(1)


Expand Down Expand Up @@ -62,10 +62,9 @@
'Operating System :: MacOS :: MacOS X',
'Operating System :: POSIX :: Linux',

'Programming Language :: Python :: 3.6',
'Programming Language :: Python :: 3.7',
'Programming Language :: Python :: 3.8',
'Programming Language :: Python :: 3.9',
],
python_requires=">=3.6.2",
python_requires=">=3.7",
)
6 changes: 3 additions & 3 deletions tox.ini
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
[tox]
skipsdist = True
envlist = py36,py37,py38,py39,flake8,mypy
envlist = py37,py38,py39,flake8,mypy

[testenv:flake8]
description = flake8 code checks
Expand All @@ -21,7 +21,7 @@ deps =
-rdev-requirements.txt
-reditable-requirements.txt

[testenv:{unit,py36,py37,py38,py39,py}]
[testenv:{unit,py37,py38,py39,py}]
description = unit testing
skip_install = true
passenv = DBT_* PYTEST_ADDOPTS
Expand All @@ -30,7 +30,7 @@ deps =
-rdev-requirements.txt
-reditable-requirements.txt

[testenv:{integration,py36,py37,py38,py39,py}-{postgres}]
[testenv:{integration,py37,py38,py39,py}-{postgres}]
description = adapter plugin integration testing
skip_install = true
passenv = DBT_* POSTGRES_TEST_* PYTEST_ADDOPTS
Expand Down

0 comments on commit 354c1e0

Please sign in to comment.