Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sources in the manifest JSON schema can have a specific data type #3966

Closed
5 tasks
yu-iskw opened this issue Sep 29, 2021 · 3 comments · Fixed by #3967
Closed
5 tasks

sources in the manifest JSON schema can have a specific data type #3966

yu-iskw opened this issue Sep 29, 2021 · 3 comments · Fixed by #3967
Labels
bug Something isn't working

Comments

@yu-iskw
Copy link
Contributor

yu-iskw commented Sep 29, 2021

Describe the bug

Some sources in the manifest JSON schema would be good to have a specific data type.
According to the JSON schema, some sources don't include their data types.

https://schemas.getdbt.com/dbt/manifest/v2.json

        "sources": {
          "type": "array",
          "items": {
            "type": "array"
          },
          "default": []
        },

Steps To Reproduce

Expected behavior

That can be an array of array of strings.

        "sources": {
          "type": "array",
          "items": {
            "type": "array",
            "items": {
              "type": "string"
            }
          },

Screenshots and log output

System information

Which database are you using dbt with?

  • postgres
  • redshift
  • bigquery
  • snowflake
  • other (specify: ____________)

Additional context

Add any other context about the problem here.

@jtcohen6
Copy link
Contributor

This seems reasonable enough to me. I can't think of a case where sources is something other than a list of strings. This change would also make the type of sources consistent with refs.

@gshank @nathaniel-may Do you see any reason to oppose this change? Or anything else we might be missing?

@jtcohen6 jtcohen6 removed the triage label Sep 30, 2021
@gshank
Copy link
Contributor

gshank commented Oct 4, 2021

I don't see any reason to oppose this.

@yu-iskw
Copy link
Contributor Author

yu-iskw commented Oct 6, 2021

@gshank I am happy to hear that. As I sent the PR #3967 , please take a look. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants