-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Change the data type of sources
of ParsedNodeDefaults
#3967
Change the data type of sources
of ParsedNodeDefaults
#3967
Conversation
e93a437
to
1423b48
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@yu-iskw Thanks for the contribution, this looks good to me! Just one teensy request before merging
CHANGELOG.md
Outdated
@@ -14,6 +14,7 @@ | |||
### Fixes | |||
- Add generic tests defined on sources to the manifest once, not twice ([#3347](https://github.com/dbt-labs/dbt/issues/3347), [#3880](https://github.com/dbt-labs/dbt/pull/3880)) | |||
- Skip partial parsing if certain macros have changed ([#3810](https://github.com/dbt-labs/dbt/issues/3810), [#3982](https://github.com/dbt-labs/dbt/pull/3892)) | |||
- Define the data type of `sources` as an array of arrays of string in the manifest artifacts. ([#3966](https://github.com/dbt-labs/dbt/issues/3966))) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could you add yourself to the list of Contributors
below?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Alright. I added.
@jtcohen6 Thank you for handling the PR! |
resolves #3966
Description
The
sources
ofParsedNodeDefaults
can beList[List[str]]
.Checklist
CHANGELOG.md
and added information about my change to the "dbt next" section.