Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change the data type of sources of ParsedNodeDefaults #3967

Merged
merged 4 commits into from
Oct 7, 2021

Conversation

yu-iskw
Copy link
Contributor

@yu-iskw yu-iskw commented Sep 29, 2021

resolves #3966

Description

The sources of ParsedNodeDefaults can be List[List[str]].

Checklist

  • I have signed the CLA
  • I have run this code in development and it appears to resolve the stated issue
  • This PR includes tests, or tests are not required/relevant for this PR
  • I have updated the CHANGELOG.md and added information about my change to the "dbt next" section.

@yu-iskw yu-iskw force-pushed the modify-manifest-json-schema branch from e93a437 to 1423b48 Compare October 6, 2021 00:02
@yu-iskw yu-iskw marked this pull request as ready for review October 6, 2021 00:46
Copy link
Contributor

@jtcohen6 jtcohen6 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@yu-iskw Thanks for the contribution, this looks good to me! Just one teensy request before merging

CHANGELOG.md Outdated
@@ -14,6 +14,7 @@
### Fixes
- Add generic tests defined on sources to the manifest once, not twice ([#3347](https://github.com/dbt-labs/dbt/issues/3347), [#3880](https://github.com/dbt-labs/dbt/pull/3880))
- Skip partial parsing if certain macros have changed ([#3810](https://github.com/dbt-labs/dbt/issues/3810), [#3982](https://github.com/dbt-labs/dbt/pull/3892))
- Define the data type of `sources` as an array of arrays of string in the manifest artifacts. ([#3966](https://github.com/dbt-labs/dbt/issues/3966)))
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you add yourself to the list of Contributors below?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Alright. I added.

@yu-iskw yu-iskw requested a review from jtcohen6 October 7, 2021 05:21
@jtcohen6 jtcohen6 merged commit 2075629 into dbt-labs:develop Oct 7, 2021
@yu-iskw
Copy link
Contributor Author

yu-iskw commented Oct 8, 2021

@jtcohen6 Thank you for handling the PR!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

sources in the manifest JSON schema can have a specific data type
2 participants