[CT-281] Make obsolete the test compare tables code now in core/dbt/tests/tables.py

[gshank]

As part of the conversion to switching from unittest to pytest, the code in test/integration/base.py that implements the five table comparison assertions was pulled into a separate file, core/dbt/tests/tables.py. There are better ways to do this, including using macros and data tests.

Implement the table comparisons in a more dbt-like way, update the new pytest tests to use it, and remove dbt.tests.tables.

[jtcohen6]

In particular, there's a lot of overlap between what's in tables.py, and what's been implemented to power the (relatively newer) suite of basic adapter tests here. Where possible, we should opt for:

• defining this functionality on the adapter
• wrapping all SQL in Jinja macros

Other current sources of jankiness, worth a second pass:

• run_sql_with_adapter + adapter.run_sql_for_tests
• This update_rows business is interesting from start to finish

[nathaniel-may]

work items:

• identify duplicate functionality in table.py vs macros + adapter methods
• convert to using macro and adapter methods where possible
• identify and create missing macro and adapter methods
• update existing tests if necessary

BigQuery will be a bit of a challenge

[gshank]

Comment in wrong pr.

[nathaniel-may]

@gshank, my comment from estimation? where does it belong?

[gshank]

Oh, you're asking about my "Comment in wrong pr." comment? That was my mistake. I put a comment here that belonged in a different PR, but github wouldn't let me remove all the text, so I just put that in... Had nothing to do with your comment :)