Initial code to use dbt.tests.adapter in Redshift #81
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gshank
force-pushed
the
ct-351-new_test_framework
branch
from
f9ccc96
to
cae3bb5
Compare
ChenyuLInx
reviewed
Mar 29, 2022
|
|
||
|
|
||
| class TestSnapshotCheckColsRedshift(BaseSnapshotCheckCols): | ||
| # Redshift defines the 'name' column such that it's not big enough |
There was a problem hiding this comment.
Should we consider updating the base case to accommodate all adapters? but can also leave this as future steps
There was a problem hiding this comment.
We can't update the base case to make Redshift work, because it requires a specific column datatype which doesn't work for all adapters.
There was a problem hiding this comment.
I do think this is related to some jank around updating these fixture tables mid-sequence, which is worth discussing further, alongside the jank we've already identified: dbt-labs/dbt-core#4778 (comment)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
resolves #78
Description
Use the new testing framework in Redshift.
Checklist
CHANGELOG.mdand added information about my change to the "dbt-redshift next" section.