Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CT-1217] [Bug] ConfigSelectorMethod should check for bools #5890

Closed
2 tasks done
danielcmessias opened this issue Sep 20, 2022 · 4 comments · Fixed by #5889
Closed
2 tasks done

[CT-1217] [Bug] ConfigSelectorMethod should check for bools #5890

danielcmessias opened this issue Sep 20, 2022 · 4 comments · Fixed by #5889
Labels
bug Something isn't working good_first_issue Straightforward + self-contained changes, good for new contributors! node selection Functionality and syntax for selecting DAG nodes

Comments

@danielcmessias
Copy link
Contributor

Is this a new bug in dbt-core?

  • I believe this is a new bug in dbt-core
  • I have searched the existing issues, and I could not find an existing issue for this bug

Current Behavior

The ConfigSelectorMethod only checks for string equality. If you have a config property that is boolean, there is no way to match it.

Consider the example:

# schema.yml
models:
  - name: some_model
    config:
      meta:
        pii: true

Then running dbt run --select config.meta.pii:true would not match.

Expected Behavior

Running dbt run --select config.meta.pii:true would include the node

Steps To Reproduce

Create a model with some metadata, e.g.

# schema.yml
models:
  - name: some_model
    config:
      meta:
        pii: true

Then run dbt run --select config.meta.pii:true

Relevant log output

No response

Environment

- OS:
- Python:
- dbt:

Which database adapter are you using with dbt?

other (mention it in "Additional Context")

Additional Context

No response

@danielcmessias danielcmessias added bug Something isn't working triage labels Sep 20, 2022
@github-actions github-actions bot changed the title [Bug] ConfigSelectorMethod should check for bools [CT-1217] [Bug] ConfigSelectorMethod should check for bools Sep 20, 2022
@danielcmessias
Copy link
Contributor Author

Token issue, resolved by #5889

@jtcohen6
Copy link
Contributor

Thanks for the issue + PR @danielcmessias!

This is very similar to #5482, which wants the ability to match an entry in a list, if config is a list.

@jtcohen6 jtcohen6 added good_first_issue Straightforward + self-contained changes, good for new contributors! node selection Functionality and syntax for selecting DAG nodes Team:Execution and removed triage labels Sep 20, 2022
@danielcmessias
Copy link
Contributor Author

danielcmessias commented Sep 20, 2022

#5482

@jtcohen6
Ah nice, I'll bake in that one liner fix into my PR since I'm here :)

@jtcohen6
Copy link
Contributor

resolved by #5889

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working good_first_issue Straightforward + self-contained changes, good for new contributors! node selection Functionality and syntax for selecting DAG nodes
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants