ConfigSelectorMethod should check for bools

[danielcmessias]

resolves

resolves #5890
resolves #5482

Description

The ConfigSelectorMethod only checks for string equality. If you have a config property that is boolean, there is no way to match it.

Consider the example:

# schema.yml
models:
  - name: some_model
    config:
      meta:
        pii: true

Then running dbt run --select config.meta.pii:true would not match. The only way for it work would be to encapsulate the property as a string (pii: "true"), not ideal.

This is a small change such that if the property is a bool, check (case-insensitively) against the strings "true" / "false".

Checklist

• I have read the contributing guide and understand what's expected of me
• I have signed the CLA
• I have run this code in development and it appears to resolve the stated issue
• This PR includes tests, or tests are not required/relevant for this PR
• I have opened an issue to add/update docs, or docs changes are not required/relevant for this PR
• I have run changie new to create a changelog entry

[cla-bot]

Thanks for your pull request, and welcome to our community! We require contributors to sign our Contributor License Agreement and we don't seem to have your signature on file. Check out this article for more information on why we have a CLA.

In order for us to review and merge your code, please submit the Individual Contributor License Agreement form attached above above. If you have questions about the CLA, or if you believe you've received this message in error, don't hesitate to ping @drewbanin.

CLA has not been signed by users: @danielcmessias

[gshank]

Could you add a test? test/unit/test_graph_selector_parsing.py looks like a good place...

[jtcohen6]

Thanks @danielcmessias! Do you feel up for adding some test cases? Relevant unit tests are here.

I'm going to mark this as ready_for_review in the meantime

Edit: Gerda beat me to it :)

[jtcohen6]

Should we support all forms of yaml truthy/falsy (0/1, "t/"f", yes/no)?

I'm fine with just "true" + "false" personally

[danielcmessias]

I'm in favour of just true/false and avoid the yaml-specify truthy/falsy rules which don't apply in Python/JSON/Jinja templates

[jtcohen6]

If it's not too far out of scope — what do you think about pulling in #5482 / code like this while you're here?

[danielcmessias]

@gshank @jtcohen6 Added a resolution for #5482 and some test cases.

Went back and forth a couple of times on the structure; idk whether separate clauses for the list and string case that both yield the node is more or less readable than one giant IF with all the conditions 🤷‍♂️ . LMK if you'd prefer it another way :)

[gshank]

Need to run pre-commit now, pip install pre-commit if it's not already installed, then run 'pre-commit run --all-files" and commit the changes.