Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CT-1339] [Feature] dbt exposures should support metrics #6057

Closed
3 tasks done
cafzal opened this issue Oct 12, 2022 · 3 comments · Fixed by #6342
Closed
3 tasks done

[CT-1339] [Feature] dbt exposures should support metrics #6057

cafzal opened this issue Oct 12, 2022 · 3 comments · Fixed by #6342
Assignees
Labels
enhancement New feature or request exposures semantic Issues related to the semantic layer support_rotation A good task to pick up during support rotation

Comments

@cafzal
Copy link

cafzal commented Oct 12, 2022

Is this your first time submitting a feature request?

  • I have read the expectations for open source contributors
  • I have searched the existing issues, and I could not find an existing issue for this feature
  • I am requesting a straightforward extension of existing dbt functionality, rather than a Big Idea better suited to a discussion

Describe the feature

As a dbt user, I want to be able to use metrics in my exposures. For example, if I have a dashboard, I should be able to add it as an exposure in my DAG, and show that it uses certain models and metrics. This is especially useful once I can directly query those metrics via the Semantic Layer.

Describe alternatives you've considered

I've tried adding metrics in my project under the ref'd models in the exposure definition (i.e. using the metric(...) syntax used to define dependencies in derived metrics), but the metrics don't appear in the lineage graph after the project compiles.

Who will this benefit?

Exposures are a great way to 'extend the DAG' and should support models and metrics. I want to see where my metrics are used and how:

  1. for overall awareness about their usage and utility
  2. to ensure any upstream changes I make don't have negative consequences downstream.

This will benefit organizations adopting dbt metrics, especially those querying them via the Semantic Layer.

Are you interested in contributing this feature?

I'm happy to give feedback and help user test the functionality!

Anything else?

No response

@cafzal cafzal added enhancement New feature or request triage labels Oct 12, 2022
@github-actions github-actions bot changed the title [Feature] dbt exposures should support metrics [CT-1339] [Feature] dbt exposures should support metrics Oct 12, 2022
@lostmygithubaccount lostmygithubaccount added support_rotation A good task to pick up during support rotation exposures metrics and removed triage labels Oct 13, 2022
@lostmygithubaccount
Copy link
Contributor

thanks @cafzal!

@cafzal
Copy link
Author

cafzal commented Nov 24, 2022

@jtcohen6 Any update on triaging/fixing this? Users can't use use metrics with exposures until it's fixed.

@jtcohen6
Copy link
Contributor

@cafzal Sorry, missed this! We could have a much longer conversation about what it means to consume a metric in an exposure. For now, I'm aligned with this being a thing that should be possible; it's what's consistent & expected.

@MichelleArk took a look, it should be fairly straightforward to implement: #6342

@MichelleArk MichelleArk self-assigned this Nov 30, 2022
@jtcohen6 jtcohen6 added the semantic Issues related to the semantic layer label Jun 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request exposures semantic Issues related to the semantic layer support_rotation A good task to pick up during support rotation
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants