Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Exposures support metrics #6342

Merged
merged 4 commits into from
Dec 1, 2022
Merged

Conversation

MichelleArk
Copy link
Contributor

@MichelleArk MichelleArk commented Nov 30, 2022

resolves #6057

Description

🎩 Did some manual tophatting to confirm lineage is visualized as expected with exposures dependent on metrics:
Screen Shot 2022-11-29 at 11 41 29 PM
Screen Shot 2022-11-29 at 11 41 19 PM

Checklist

@cla-bot cla-bot bot added the cla:yes label Nov 30, 2022
@github-actions
Copy link
Contributor

Thank you for your pull request! We could not find a changelog entry for this change. For details on how to document a change, see the contributing guide.

1 similar comment
@github-actions
Copy link
Contributor

Thank you for your pull request! We could not find a changelog entry for this change. For details on how to document a change, see the contributing guide.

@MichelleArk MichelleArk force-pushed the CT-1339-exposures-support-metrics branch from 2b341fd to a3d9bf4 Compare November 30, 2022 05:49
@MichelleArk MichelleArk changed the title exposures support metrics Exposures support metrics Nov 30, 2022
Copy link
Contributor

@jtcohen6 jtcohen6 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think just a (functional?) test where we define an exposure that depends on a metric, and validate that the value appears in the appropriate node properties (metrics, depends_on.nodes).

exposures:
  - name: some_exposure
    depends_on:
      - metric('some_metric')

And then this will be good to go! Nice work making it happen

@MichelleArk MichelleArk force-pushed the CT-1339-exposures-support-metrics branch from 1015080 to 96b9c1c Compare November 30, 2022 20:15
@MichelleArk MichelleArk marked this pull request as ready for review November 30, 2022 21:07
@MichelleArk MichelleArk requested review from a team as code owners November 30, 2022 21:07
Copy link
Contributor

@gshank gshank left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[CT-1339] [Feature] dbt exposures should support metrics
3 participants