-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Exposures support metrics #6342
Conversation
Thank you for your pull request! We could not find a changelog entry for this change. For details on how to document a change, see the contributing guide. |
1 similar comment
Thank you for your pull request! We could not find a changelog entry for this change. For details on how to document a change, see the contributing guide. |
2b341fd
to
a3d9bf4
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think just a (functional?) test where we define an exposure that depends on a metric, and validate that the value appears in the appropriate node properties (metrics
, depends_on.nodes
).
exposures:
- name: some_exposure
depends_on:
- metric('some_metric')
And then this will be good to go! Nice work making it happen
1015080
to
96b9c1c
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good!
resolves #6057
Description
🎩 Did some manual tophatting to confirm lineage is visualized as expected with exposures dependent on metrics:
Checklist
changie new
to create a changelog entry