Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CT-3147] [Implementation] update config block names for data tests and unit tests #8699

Closed
1 task done
Tracked by #8283
graciegoheen opened this issue Sep 22, 2023 · 3 comments
Closed
1 task done
Tracked by #8283
Assignees
Labels
Impact: Exp user docs [docs.getdbt.com] Needs better documentation

Comments

@graciegoheen
Copy link
Contributor

graciegoheen commented Sep 22, 2023

Housekeeping

  • I am a maintainer of dbt-core

Short description

From #8606

We should updating the config names

  • from unit: -> unit-tests:
  • and tests: -> data-tests: (we should preserve tests: for backwards compatibility)

In dbt_project.yml:

data-tests:
...
unit-tests:

as well as in schema yml files:

models:
  - name: orders
    columns:
      - name: order_id
        data_tests:
          - unique
          - not_null

Acceptance criteria

  • config name for unit tests is unit-tests:
  • config name for data tests is data-tests: or tests: (the latter for backwards compatibility)
  • deprecation warning for tests:

Impact to Other Teams

None

Will backports be required?

None

Context

No response

@graciegoheen graciegoheen added the user docs [docs.getdbt.com] Needs better documentation label Sep 22, 2023
@github-actions github-actions bot changed the title [Implementation] update config block names for data tests and unit tests [CT-3147] [Implementation] update config block names for data tests and unit tests Sep 22, 2023
@graciegoheen
Copy link
Contributor Author

graciegoheen commented Oct 9, 2023

Notes from refinement:

  • what happens if someone passes in both tests: and data-tests:? we will not support both
  • deprecation warning for tests:

@emmyoop
Copy link
Member

emmyoop commented Nov 10, 2023

unit-tests was converted in #8988

@emmyoop
Copy link
Member

emmyoop commented Dec 12, 2023

This was completed by #9201

@emmyoop emmyoop closed this as completed Dec 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Impact: Exp user docs [docs.getdbt.com] Needs better documentation
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants