convert test to data_test

[emmyoop]

resolves #8699

Problem

With the addition of unit_tests the config for tests is confusing as it currently does not include unit_tests, only data_tests.

Solution

Explicitly define data_tests as data_tests in both schema files and in dbt_project.yml.

Also updated unit-tests to be unit_tests in dbt_project.yml for consistency.

Continue to support the tests config for backwards compatibility but add a deprecation warning for it.

Checklist

• I have read the contributing guide and understand what's expected of me
• I have run this code in development and it appears to resolve the stated issue
• This PR includes tests, or tests are not required/relevant for this PR
• This PR has no interface changes (e.g. macros, cli, logs, json artifacts, config files, adapter interface, etc) or this PR has already received feedback and approval from Product or DX
• This PR includes type annotations for new and modified functions

[github-actions]

Thank you for your pull request! We could not find a changelog entry for this change. For details on how to document a change, see the contributing guide.

[codecov]

Codecov Report

Attention: 32 lines in your changes are missing coverage. Please review.

Comparison is base (ca82f54) 86.89% compared to head (4613425) 64.85%.

Files	Patch %	Lines
core/dbt/contracts/files.py	61.11%	7 Missing ⚠️
core/dbt/contracts/graph/nodes.py	75.00%	5 Missing ⚠️
core/dbt/exceptions.py	33.33%	4 Missing ⚠️
core/dbt/parser/generic_test_builders.py	63.63%	4 Missing ⚠️
core/dbt/parser/schemas.py	70.00%	3 Missing ⚠️
core/dbt/contracts/project.py	75.00%	2 Missing ⚠️
core/dbt/parser/common.py	80.00%	2 Missing ⚠️
core/dbt/parser/schema_generic_tests.py	71.42%	2 Missing ⚠️
core/dbt/task/test.py	33.33%	2 Missing ⚠️
core/dbt/parser/sources.py	0.00%	1 Missing ⚠️

Additional details and impacted files

@@                       Coverage Diff                        @@
##           unit_testing_feature_branch    #9201       +/-   ##
================================================================
- Coverage                        86.89%   64.85%   -22.05%     
================================================================
  Files                              180      180               
  Lines                            27127    27171       +44     
================================================================
- Hits                             23572    17621     -5951     
- Misses                            3555     9550     +5995     

Flag	Coverage Δ
integration	?
unit	64.85% <73.33%> (-0.01%)	⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[gshank]

@graciegoheen The ticket that's referenced is contradictory about whether the config key in yaml should be "data-tests" or "data_tests". Which do you want in schema.yml?

[graciegoheen]

@gshank My understanding was that it had to have _ in the schema yml files and - in the dbt_project.yml file (similar to how we handle semantic models - semantic_models in schema yml, semantic-models in dbt_project.yml).

Let me know if that understanding was incorrect.

[emmyoop]

Using dash in the dbt_project.yml and underscore in the schema files is also the pattern used elsewhere. semantic-models are another config we uses dashes in one place and underscores in another. It was also decided to do this for unit-tests as implemented in #8988

[graciegoheen]

@emmyoop To confirm for our docs - we're using underscores for data_tests and unit_tests everywhere?

[emmyoop]

@graciegoheen yes! Underscores everywhere for unit_tests and data_tests!

Nothing else was modified that's called out in #9235.