Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update unit test key: unit -> unit-tests #8988

Merged
merged 3 commits into from
Nov 3, 2023

Conversation

emmyoop
Copy link
Member

@emmyoop emmyoop commented Nov 2, 2023

resolves #8698
#8966 resolves the other half of this ticket

Problem

We don't want the top level yaml key for unit tests to be unit

Solution

Make the top level key unit-tests

Checklist

  • I have read the contributing guide and understand what's expected of me
  • I have run this code in development and it appears to resolve the stated issue
  • This PR includes tests, or tests are not required/relevant for this PR
  • This PR has no interface changes (e.g. macros, cli, logs, json artifacts, config files, adapter interface, etc) or this PR has already received feedback and approval from Product or DX
  • This PR includes type annotations for new and modified functions

@cla-bot cla-bot bot added the cla:yes label Nov 2, 2023
Copy link
Contributor

github-actions bot commented Nov 2, 2023

Thank you for your pull request! We could not find a changelog entry for this change. For details on how to document a change, see the contributing guide.

Copy link

codecov bot commented Nov 2, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (aa91ea4) 86.63% compared to head (de98e61) 86.66%.

Additional details and impacted files
@@                       Coverage Diff                       @@
##           unit_testing_feature_branch    #8988      +/-   ##
===============================================================
+ Coverage                        86.63%   86.66%   +0.02%     
===============================================================
  Files                              181      181              
  Lines                            26979    26976       -3     
===============================================================
+ Hits                             23374    23378       +4     
+ Misses                            3605     3598       -7     
Flag Coverage Δ
integration 83.53% <100.00%> (+0.02%) ⬆️
unit 64.65% <66.66%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
core/dbt/config/project.py 97.42% <ø> (ø)
core/dbt/contracts/graph/model_config.py 92.60% <ø> (ø)
core/dbt/contracts/project.py 97.76% <ø> (ø)
core/dbt/parser/partial.py 93.73% <100.00%> (ø)
core/dbt/parser/schemas.py 92.00% <100.00%> (ø)
core/dbt/parser/unit_tests.py 93.51% <100.00%> (ø)

... and 3 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@emmyoop emmyoop added the Skip Changelog Skips GHA to check for changelog file label Nov 2, 2023
@emmyoop emmyoop marked this pull request as ready for review November 2, 2023 19:56
@emmyoop emmyoop requested a review from a team as a code owner November 2, 2023 19:56
@emmyoop emmyoop requested review from ChenyuLInx, MichelleArk and gshank and removed request for ChenyuLInx November 2, 2023 19:56
@emmyoop emmyoop merged commit 02a3dc5 into unit_testing_feature_branch Nov 3, 2023
53 of 54 checks passed
@emmyoop emmyoop deleted the er/8698-unit-test-block branch November 3, 2023 18:17
@emmyoop emmyoop mentioned this pull request Dec 5, 2023
5 tasks
gshank added a commit that referenced this pull request Jan 16, 2024
* Initial implementation of unit testing (from pr #2911)

Co-authored-by: Michelle Ark <michelle.ark@dbtlabs.com>

* 8295 unit testing artifacts (#8477)

* unit test config: tags & meta (#8565)

* Add additional functional test for unit testing selection, artifacts, etc (#8639)

* Enable inline csv format in unit testing (#8743)

* Support unit testing incremental models (#8891)

* update unit test key: unit -> unit-tests (#8988)


* convert to use unit test name at top level key (#8966)

* csv file fixtures (#9044)

* Unit test support for `state:modified` and `--defer` (#9032)

Co-authored-by: Michelle Ark <michelle.ark@dbtlabs.com>

* Allow use of sources as unit testing inputs (#9059)

* Use daff for diff formatting in unit testing (#8984)

* Fix #8652: Use seed file from disk for unit testing if rows not specified in YAML config (#9064)

Co-authored-by: Michelle Ark <MichelleArk@users.noreply.github.com>
Fix #8652: Use seed value if rows not specified

* Move unit testing to test and build commands (#9108)

* Enable unit testing in non-root packages (#9184)

* convert test to data_test (#9201)

* Make fixtures files full-fledged members of manifest and enable partial parsing (#9225)

* In build command run unit tests before models (#9273)

---------

Co-authored-by: Michelle Ark <michelle.ark@dbtlabs.com>
Co-authored-by: Michelle Ark <MichelleArk@users.noreply.github.com>
Co-authored-by: Emily Rockman <emily.rockman@dbtlabs.com>
Co-authored-by: Jeremy Cohen <jeremy@dbtlabs.com>
Co-authored-by: Kshitij Aranke <kshitij.aranke@dbtlabs.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla:yes Skip Changelog Skips GHA to check for changelog file
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants