-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Run check_if_can_write_profile before create_profile_using_project_profile_template [CT-67] [Backport 1.0.latest] #4447
Run check_if_can_write_profile before create_profile_using_project_profile_template [CT-67] [Backport 1.0.latest] #4447
Conversation
@@ -285,6 +285,8 @@ def run(self): | |||
# just setup the user's profile. | |||
fire_event(SettingUpProfile()) | |||
profile_name = self.get_profile_name_from_current_project() | |||
if not self.check_if_can_write_profile(profile_name=profile_name): |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🙈
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Thanks for the contribution
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Putting this on hold-- PR is fine, but I wasn't able to reproduce the issue locally with or without this PR. Additional conversation in linked ticket.
Edit: Resolved. Merging PR
…ofile_template [CT-67] [Backport 1.0.latest] (#4447) * Run check_if_can_write_profile before create_profile_using_project_profile_template * Changelog Co-authored-by: Ian Knox <81931810+iknox-fa@users.noreply.github.com>
…ofile_template [CT-67] [Backport 1.0.latest] (#4447) (#4658) * Run check_if_can_write_profile before create_profile_using_project_profile_template * Changelog Co-authored-by: Ian Knox <81931810+iknox-fa@users.noreply.github.com> Co-authored-by: Niall Woodward <niall@niallrees.com> Co-authored-by: Ian Knox <81931810+iknox-fa@users.noreply.github.com>
Resolves #4375
Description
Checklist
CHANGELOG.md
and added information about my change