Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CT-159 Remove docs file from manifest when deleting doc node #5270

Merged
merged 4 commits into from
May 19, 2022

Conversation

gshank
Copy link
Contributor

@gshank gshank commented May 18, 2022

resolves #4146

Description

Remove docs file from manifest when deleting doc node/file.

Checklist

@gshank gshank requested review from a team as code owners May 18, 2022 17:45
@cla-bot cla-bot bot added the cla:yes label May 18, 2022
@github-actions
Copy link
Contributor

Thank you for your pull request! We could not find a changelog entry for this change. For details on how to document a change, see the contributing guide.

Copy link
Contributor

@ChenyuLInx ChenyuLInx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@gshank gshank self-assigned this May 19, 2022
@gshank gshank merged commit cda88d1 into main May 19, 2022
@gshank gshank deleted the ct-159-pp_docs_block branch May 19, 2022 15:37
agoblet pushed a commit to BigDataRepublic/dbt-core that referenced this pull request May 20, 2022
…s#5270)

* Convert partial parsing docs tests

* Failing test

* Remove doc file from manifest when doc node is removed

* Changie
github-actions bot pushed a commit that referenced this pull request May 23, 2022
* Convert partial parsing docs tests

* Failing test

* Remove doc file from manifest when doc node is removed

* Changie

(cherry picked from commit cda88d1)
gshank added a commit that referenced this pull request Jun 1, 2022
…ting doc node (#5293)

* CT-159 Remove docs file from manifest when deleting doc node (#5270)

* Convert partial parsing docs tests

* Failing test

* Remove doc file from manifest when doc node is removed

* Changie

(cherry picked from commit cda88d1)

* Fix rm_file method

* comment out pip upgrade

Co-authored-by: Gerda Shank <gerda@dbtlabs.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[CT-159] [Bug] Partial parsing fails to find new doc block after git pull
2 participants