Extended validations for the project names #5620
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jtcohen6
added
Team:Execution
ready_for_review
|
Please, review this. |
stu-k
suggested changes
Aug 10, 2022
Co-authored-by: Stu Kilgore <stuart.kilgore@gmail.com>
|
@stu-k Thank you for the review. For me it does also make sense. Since we are facing the issue with getting adapter plugins during the init process. |
stu-k
approved these changes
Aug 10, 2022
|
Looks good to me! |
Can you merge it? |
|
@Goodkat Merged!! Thanks for contributing this!! |
VersusFacit
pushed a commit
that referenced
this pull request
Sep 5, 2022
agoblet
pushed a commit
to BigDataRepublic/dbt-core
that referenced
this pull request
Sep 16, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
resolves #5379
Description
In response to the issue #5379
We need to check that the user-provided project name doesn't match
dbt, a.k.a.GLOBAL_PROJECT_NAMEas well as the user-provided name also doesn't collide with one of the installed plugins' reserved package names (dbt_snowflake,dbt_bigquery, etc).Checklist
changie newto create a changelog entry