-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Timle/dbt deps tarball (branch rename) #6302
Conversation
in support of dbt-labs#4205
sha1: allow user to specify sha1 in packages.yaml, will only install if package matches subdirectory: allow user to specify subdirectory of package in tarfile, if the package is a non standard structure (like with git subdirectory option)
will hit url multiple times instead
- remove tarfile passing, always use tempfile instead - reorganize system.* functions, removing duplicative code - more notes on current flow and structure - esp need for pattern of 1) unpack 2) scan for package dir 3) copy to destination. - cleaning
removing sha1 check to simplify/mirror hub install pattern
to simplify/mirror hub install pattern - removing sha1 check - supply name/version to act as our 'metadata' source
simplify with goal of mirroring hub install pattern - supporting subfolders like git packages, and sha1 checks are removed - existing code from RegistryPinnedPackage (install() and download_and_untar()) performs the operations - RegistryPinnedPackage install() and download_and_untar() are not currently set up as functions that can be used across classes - this should be moved to dbt.deps.base, or to a dbt.deps.common file - need dbt labs feedback on how to proceed (or leave as is)
more complex features have been removed (sha1, subfolder) so testing is much simpler!
remove version from package folder name
i'm on the fence if this is right approach, but seems like most sensible after some thought
debugging #4689 where it was suggested that I try a different branch name |
thanks for the assist here @dbeatty10 - looks like #4689 has started to run the tests properly again. Should I continue the PR here (new location, update branch name) or resume at #4689 (original location, original branch name)? |
@timle2 awesome you got it working again! You can close this one and resume with the original pull request location and original branch name. |
Continued from
#4689
Continued from
#4220
Revision 3 added Nov 6 2022
in support of Issue [Feature] add new dbt.deps type: url to internally hosted tarball #4205
Proposed solution for feature request 4205
Description
Enable direct linking to tarball urls in
packages.yml
, for example:Rational:
Sketching out doc changes here:
https://github.com/timle2/docs.getdbt.com/blob/dbt-docs-tarball-package-updates/website/docs/docs/building-a-dbt-project/package-management.md#tar-files
Checklist
CHANGELOG.md
and added information about my change