Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add cache to SavedQueryConfig #9588

Merged
merged 3 commits into from
Feb 16, 2024
Merged

add cache to SavedQueryConfig #9588

merged 3 commits into from
Feb 16, 2024

Conversation

emmyoop
Copy link
Member

@emmyoop emmyoop commented Feb 16, 2024

resolves #9540

Problem

SL needs us to support a cache property for SavedQuery

Solution

Add cache to SavedQueryConfig.

Checklist

  • I have read the contributing guide and understand what's expected of me
  • I have run this code in development and it appears to resolve the stated issue
  • This PR includes tests, or tests are not required/relevant for this PR
  • This PR has no interface changes (e.g. macros, cli, logs, json artifacts, config files, adapter interface, etc) or this PR has already received feedback and approval from Product or DX
  • This PR includes type annotations for new and modified functions

@cla-bot cla-bot bot added the cla:yes label Feb 16, 2024
Copy link

codecov bot commented Feb 16, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (8a1b927) 87.94% compared to head (4c9ea34) 87.94%.
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #9588   +/-   ##
=======================================
  Coverage   87.94%   87.94%           
=======================================
  Files         168      168           
  Lines       22208    22212    +4     
=======================================
+ Hits        19531    19535    +4     
  Misses       2677     2677           
Flag Coverage Δ
integration 85.53% <100.00%> (+<0.01%) ⬆️
unit 61.93% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@emmyoop emmyoop added the artifact_minor_upgrade To bypass the CI check by confirming that the change is not breaking label Feb 16, 2024
@emmyoop emmyoop marked this pull request as ready for review February 16, 2024 15:28
@emmyoop emmyoop requested a review from a team as a code owner February 16, 2024 15:28
@emmyoop emmyoop changed the title add cache to saved query config add cache to SavedQueryConfig Feb 16, 2024
@emmyoop emmyoop requested review from QMalcolm and removed request for ChenyuLInx February 16, 2024 15:29
Copy link
Contributor

@QMalcolm QMalcolm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It makes me so happy that the actual change only has to be 4 lines and everything else is tests. Looks great! 🚢

@emmyoop emmyoop merged commit c7522d2 into main Feb 16, 2024
52 checks passed
@emmyoop emmyoop deleted the er/9540-saved-query-cache branch February 16, 2024 20:31
@emmyoop emmyoop added the user docs [docs.getdbt.com] Needs better documentation label Feb 16, 2024
@FishtownBuildBot
Copy link
Collaborator

Opened a new issue in dbt-labs/docs.getdbt.com: dbt-labs/docs.getdbt.com#4946

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
artifact_minor_upgrade To bypass the CI check by confirming that the change is not breaking cla:yes user docs [docs.getdbt.com] Needs better documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[SL] Add cache configuration to SavedQuery config
5 participants