Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

updating test of Number type check from boolean to 0,1 #58

Merged
merged 5 commits into from
Jan 5, 2022
Merged

updating test of Number type check from boolean to 0,1 #58

Show file tree
Hide file tree
Changes from 4 commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
c59f698
updating test of Number type check from boolean to 0,1
McKnight-42 Jan 4, 2022
ae7303e
update changelog
McKnight-42 Jan 4, 2022
13ce30f
removing draft contributing file
McKnight-42 Jan 4, 2022
1f6383c
Merge branch 'main' into mcknight/Number_type_fix
McKnight-42 Jan 4, 2022
15c63f7
Merge branch 'main' into mcknight/Number_type_fix
McKnight-42 Jan 5, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
7 changes: 6 additions & 1 deletion CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,9 @@
## dbt-redshift 1.0.0 (Release TBD)
## dbt-redshift 1.0.1 (TBD)

### Fixes
- Fix test related to preventing coercion of boolean values (True,False) to numeric values (0,1) in query results ([#58](https://github.com/dbt-labs/dbt-redshift/blob/1.0.latest/CHANGELOG.md))

## dbt-redshift 1.0.0 (December 3, 2021)

## dbt-redshift 1.0.0rc2 (November 24, 2021)

Expand Down
2 changes: 1 addition & 1 deletion tests/unit/utils.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -253,7 +253,7 @@ def _get_tester_for(self, column_type):
return agate.TimeDelta()

for instance in agate_helper.DEFAULT_TYPE_TESTER._possible_types:
if type(instance) is column_type:
if isinstance(instance, column_type):
return instance

raise ValueError(f'no tester for {column_type}')
Expand Down