Reload method and update version #133
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ChenyuLInx
commented
May 2, 2023
| ) | ||
| raise RPCException.from_error(dbt_error(exc, logs=_dict_logs(task_logs))) | ||
|
|
||
|
|
There was a problem hiding this comment.
This is the new endpoint, the rest are mostly format
davidharting
approved these changes
May 2, 2023
Comment on lines
+263
to
+264
| os.kill(os.getpid(), signal.SIGHUP) | ||
| return os.getpid() |
There was a problem hiding this comment.
Ah! I was a bit surprised by this, but it makes sense.
- Instead of actually performing a sighup, I was instead expecting this to execute the sighup handler.
This ensures the most compatibility with existing behavior, though. - I am a bit confused on the
SigTnaming. I'm not sure what that means. I was expecting this class to be named likeReloadSomethingOrOther - So we would call this with a pyaload that contains
{"method": "reload"}? Easy enough! - Will the reload happen synchronously - within band of the api call? Or will a subprocess be started that then runs
handle_request?
There was a problem hiding this comment.
I chose this because it ensures the most compatibility with existing behavior.
Thanks!! Renamed SigT to Reload in both class and params.
Will the reload happen synchronously:
No, I am not exactly sure whether it is a subprocess or not but this is matches exact behavior of current Sighup signal to rpc
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.