Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Spec Update] Move default_agg_time to be in default struct within SemanticModel #50

Closed
3 tasks done
Tracked by #7
callum-mcdata opened this issue May 17, 2023 · 1 comment
Closed
3 tasks done
Tracked by #7

[Spec Update] Move default_agg_time to be in default struct within SemanticModel #50

callum-mcdata opened this issue May 17, 2023 · 1 comment
Labels
enhancement New feature or request Protocol Spec Change

Comments

@callum-mcdata
Copy link
Contributor

Is this your first time submitting a feature request?

  • I have read the expectations for open source contributors
  • I have searched the existing issues, and I could not find an existing issue for this feature
  • I am requesting a straightforward change to existing dbt-semantic-interfaces functionality, rather than a Big Idea better suited to a discussion

Describe the feature

This is a follow up after #49 . In reality this is more of a semantic model property than it is a dimension property.

Describe alternatives you've considered

No response

Who will this benefit?

No response

Are you interested in contributing this feature?

No response

Anything else?

No response
@callum-mcdata callum-mcdata added the enhancement New feature or request label May 17, 2023
@callum-mcdata callum-mcdata mentioned this issue May 17, 2023
Closed
@marcodamore marcodamore changed the title [Feature] Move default_agg_time to be SemanticModel attribute [Spec Update] Move default_agg_time to be SemanticModel attribute May 23, 2023
@marcodamore marcodamore changed the title [Spec Update] Move default_agg_time to be SemanticModel attribute [Spec Update] Move default_agg_time to be in default struct within SemanticModel May 23, 2023
This was referenced May 23, 2023
Closed
Closed
plypaul added a commit that referenced this issue May 30, 2023
@plypaul
Add change log for #50.
5d73a82
plypaul added a commit that referenced this issue May 30, 2023
@plypaul
Add change log for #50.
fa21754
plypaul added a commit that referenced this issue May 31, 2023
@plypaul
Add change log for #50.
d4c32e2
@QMalcolm
Copy link
Collaborator

Resolved by #79

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request Protocol Spec Change
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@QMalcolm @callum-mcdata