Renaming is_primary to default_agg_time
#58
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I'll clean up this PR's history on Monday |
QMalcolm
force-pushed
the
renaming-is-primary-to-default-agg-time
branch
from
0316a90
to
875d433
Compare
tlento
reviewed
May 22, 2023
There was a problem hiding this comment.
I never liked agg_time_dimension, and so I don't like default_agg_time either (and honestly I think this should be default_agg_time_dimension if we do stick with this nomenclature).
That said, I have no better suggestions. I do think the default marker should have the same name. It might be worth a one-shot brainstorm on better names for the overall construct.
I'm not approving this just yet because @plypaul also had some idea about a default settings construct, so we should probably spend a few minutes making sure we don't want to go in that direction just yet.
|
Closed in favor of #50 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
resolves #49
Description
This is a draft PR. I'm not in love with the name
default_agg_time🤔Checklist
changie newto create a changelog entry