Relax Dependencies for Better Compatibility with Other Projects #112
Conversation
pyproject.toml
Outdated
| "typing-extensions~=4.6.1", | ||
| "more-itertools~=8.0", | ||
| "Jinja2~=3.0", | ||
| "click>=7.0", |
There was a problem hiding this comment.
We should probably cap click if we're specifying >= I think we support 8.x so perhaps "click>=7.0,<9.0"
There was a problem hiding this comment.
I don't have much context on the click dependency, but made that update.
plypaul
force-pushed
the
plypaul--42--relax-deps
branch
from
732662b
to
af85282
Compare
| "importlib_metadata==6.6.0", | ||
| "typing-extensions~=4.6.1", | ||
| "more-itertools~=8.0", | ||
| "Jinja2~=3.0", |
There was a problem hiding this comment.
Are we certain this is not too flexible? I think we are probably ok here since this will always be brought into dbt and Metricflow packages which will have their own restrictions, but I'm wondering if Jinja 3.2 could possibly include a breaking change for us
There was a problem hiding this comment.
It's a little hard to verify all package version combinations, so I figure going by tests in dbt / MF is reasonably sufficient.
There was a problem hiding this comment.
Also, if 3.2 includes a breaking change, it wouldn't be considered compatible with 3.0?
Resolves #111
Description
Please see linked issue.
Checklist
changie newto create a changelog entry