Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Relax Dependencies for Better Compatibility with Other Projects #112

Merged
merged 3 commits into from
Jul 12, 2023
Merged

Relax Dependencies for Better Compatibility with Other Projects #112

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
767eac1
Relax dependencies for better compatibility with other projects.
plypaul Jul 11, 2023
af85282
Add change log for #111.
plypaul Jul 11, 2023
5fcb77c
Remove left over override method.
plypaul Jul 11, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions .changes/unreleased/Dependencies-20230711-141108.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,6 @@
kind: Dependencies
body: elax Dependencies for Better Compatibility with Other Projects
time: 2023-07-11T14:11:08.034583-07:00
custom:
Author: plypaul
PR: "111"
5 changes: 0 additions & 5 deletions dbt_semantic_interfaces/implementations/semantic_version.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,16 +9,11 @@
PydanticCustomInputParser,
PydanticParseableValueType,
)
from dbt_semantic_interfaces.protocols.semantic_version import SemanticVersion


class PydanticSemanticVersion(PydanticCustomInputParser, HashableBaseModel):
"""Pydantic implementation of SemanticVersion."""

@override
def _implements_protocol(self) -> SemanticVersion:
return self

major_version: str
minor_version: str
patch_version: Optional[str]
Expand Down
38 changes: 19 additions & 19 deletions pyproject.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,15 +20,15 @@ classifiers = [
"Programming Language :: Python :: Implementation :: PyPy",
]
dependencies = [
"pydantic~=1.10.8",
"jsonschema==3.2.0",
"pydantic~=1.10",
"jsonschema~=3.0",
"PyYAML~=6.0",
"more-itertools==8.10.0",
"Jinja2==3.1.2",
"click>=7.1.2",
"python-dateutil==2.8.2",
"importlib_metadata==6.6.0",
"typing-extensions~=4.6.1",
"more-itertools~=8.0",
"Jinja2~=3.0",
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are we certain this is not too flexible? I think we are probably ok here since this will always be brought into dbt and Metricflow packages which will have their own restrictions, but I'm wondering if Jinja 3.2 could possibly include a breaking change for us

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's a little hard to verify all package version combinations, so I figure going by tests in dbt / MF is reasonably sufficient.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also, if 3.2 includes a breaking change, it wouldn't be considered compatible with 3.0?

"click>=7.0,<9.0",
"python-dateutil~=2.0",
"importlib_metadata~=6.0",
"typing-extensions~=4.0",
]

[build-system]
Expand All @@ -53,19 +53,19 @@ all = ["pre-commit run --all-files"]
[tool.hatch.envs.dev-env]
description = "Env for running development commands like pytest / pre-commit"
dependencies = [
"pytest~=7.3.0",
"pytest-xdist~=3.2.1",
"httpx~=0.24.0",
"pre-commit~=3.2.2",
"isort~=5.12.0",
"black~=23.3.0",
"pytest~=7.3",
"pytest-xdist~=3.2",
"httpx~=0.24",
"pre-commit~=3.2",
"isort~=5.12",
"black~=23.3",
"ruff~=0.0.260",
"mypy~=1.3.0",
"pytest~=7.3.0",
"types-Jinja2~=2.11.9",
"mypy~=1.3",
"pytest~=7.3",
"types-Jinja2~=2.11",
"types-jsonschema~=4.17",
"types-python-dateutil~=2.8.19",
"types-PyYAML~=6.0.12",
"types-python-dateutil~=2.8",
"types-PyYAML~=6.0",
]

[tool.ruff]
Expand Down
Loading