Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jpmmcneill/spark type boolean #471

Merged
merged 2 commits into from
Sep 22, 2022
Merged

Jpmmcneill/spark type boolean #471

merged 2 commits into from
Sep 22, 2022

Conversation

jpmmcneill
Copy link
Contributor

resolves #470

Description

spark component of dbt-labs/dbt-core#5739

Checklist

@cla-bot cla-bot bot added the cla:yes label Sep 19, 2022
@dbeatty10 dbeatty10 added the ready_for_review Externally contributed PR has functional approval, ready for code review from Core engineering label Sep 20, 2022
@dbeatty10
Copy link
Contributor

@jpmmcneill Now that dbt-labs/dbt-core#5875 has been merged, just one thing and then this should be ready!

  1. Restore the original version of dbt-requirements.txt

If all looks good after CI runs, then we'll merge.

@jpmmcneill
Copy link
Contributor Author

jpmmcneill commented Sep 22, 2022

@dbeatty10
Copy link
Contributor

@dbeatty10 it looks like tests were failing here. https://app.circleci.com/pipelines/github/dbt-labs/dbt-spark/1336/workflows/81d9768c-0e67-46b0-b63d-20f12c6c875f/jobs/5497 I'm taking a look

Something unique about dbt-spark is that it supports several different connection methods, and we try to test all of them.
Unfortunately, we have a couple tests related to these connections that are very flakey and often fail. Since they are flakey (not real issues), we've just been ignoring these failures.

On our side, it might be worth considering if we want to just disable those CI workflows for now if we're not paying attention to them anyways.

@dbeatty10 dbeatty10 merged commit 8c921d0 into dbt-labs:main Sep 22, 2022
ueshin added a commit to databricks/dbt-databricks that referenced this pull request Sep 23, 2022
### Description

Adds a test for `type_boolean` macro introduced at dbt-labs/dbt-core#5739, following dbt-labs/dbt-spark#471.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla:yes ready_for_review Externally contributed PR has functional approval, ready for code review from Core engineering
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[CT-1212] [Feature] Cross-database macro for type_boolean()
2 participants