Fix fanout in customers model #20
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… off of subtotal + taxpaid
gwenwindflower
commented
Mar 29, 2024
Taskfile.yml
Outdated
There was a problem hiding this comment.
We expect Cloud CLI to be installed by brew so no venv activation needed for these
gwenwindflower
commented
Mar 29, 2024
dbt_project.yml
Outdated
There was a problem hiding this comment.
This is the version sqlfluff installs by default in the pre-commit hook environment via sqlfluff-dbt-templater so we need to allow for it, although I anticipated primarily dbt Cloud CLI with versionless as the prime target for this project
gwenwindflower
commented
Mar 29, 2024
| @@ -6,7 +6,7 @@ orders as ( | |||
|
|
|||
| ), | |||
|
|
|||
| order_items_table as ( | |||
| order_items as ( | |||
There was a problem hiding this comment.
we no longer need to do this renaming as this was for a DuckDB issue
gwenwindflower
commented
Mar 29, 2024
| @@ -1,6 +1,9 @@ | |||
| models: | |||
| - name: customers | |||
| description: Customer overview data mart, offering key details for each unique customer. One row per customer. | |||
| tests: | |||
| - dbt_utils.expression_is_true: | |||
| expression: "lifetime_spend_pretax + lifetime_tax_paid = lifetime_spend" | |||
There was a problem hiding this comment.
This is the core thing this PR exists to make true
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #1
This turned into pulling a sweater thread that unravelled some issues in the source data, so I had to dig in to quite a bit!