Fix timing perfromance and user-agent models

[sphinks]

Fixing issue #40

[drewbanin]

@sphinks I just kicked off the tests and it looks like everything is passing. That's probably because we're not currently testing these "optional" models though 🙃

This change may break existing projects, but I think it's good to be consistent with Snowplow's field names. Let me give this a quick spin locally to make sure we're in good shape, and then I think we can merge this!

[drewbanin]

I gave this another look with some fresh eyes and have a couple of quick questions!

[drewbanin]

hmm, does the web_page_context model have a field called id? I think at present, web_page_context exposes two fields:

• root_id
• page_view_id

Does this work?

[drewbanin]

same here -- I don't believe there's an id field in the snowplow_base_web_page_context model?

i was wrong

[drewbanin]

Gosh... this code is kind of a mess.... So these optional models select directly from the web_page_context base model. I get it.

I think that we can indeed select the id column (as you have in this PR) or we could switch it to use the snowplow_web_page_context model which includes

1. renamed fields
2. deduplicated rows

Curious to hear which of these approaches you think is preferable

[sphinks]

Let me a dig a little deeper, because I check at my side and for sure I get an error:

column wp.page_view_id does not exist
compiled SQL at target/compiled/snowplow/page_views/optional/snowplow_web_timing_context.sql

in case of original code. We'll take a look on you comment, to understand the rootcause.

[drewbanin]

Cool, thanks @sphinks! I appreciate your help and insight here :)

Let me know what you find!

[sphinks]

@drewbanin Have reverted rename of fields and switch referencing from base model to preprocessed web context model, to reuse de-duplication and all the rest code. Please, take a look.

[drewbanin]

Thanks @sphinks, this LGTM! Will merge this today

[sphinks]

@drewbanin Great!