Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cleanup boards.txt #266

Merged
merged 5 commits into from
Apr 16, 2023
Merged

Cleanup boards.txt #266

merged 5 commits into from
Apr 16, 2023

Conversation

dbuezas
Copy link
Owner

@dbuezas dbuezas commented Apr 15, 2023

The boards.txt file became unnecessarily big.
This PR reduces its size from 414 to 87 lines without losing features by:

  • Removing all lines which were already commented out
  • Removing dedicated boards for external clocks
  • Adding 32, 16 and 12MHz external clocks to the clock source selection
  • Changing the Clock menu to a generic Clock Divider menu that works with all clock sources and crystals.

image

image

image

image

Specifically, it:

  • Removed Larduino Uno (same as the 328D variant)
  • Removed LGT8F88D (was already commented out)
  • Removed dedicated boards for 16 and 12 MHz external clocks (clock source & divider now independent)
  • Removed 328D-SSOP20 (was already commented out)

* Removed Larduino Uno (same as the 328D variant)
* Removed LGT8F88D (was already commented out)
* Removed dedicated boards for 16 and 12 MHz external clocks (clock source & divider now independent)
* Removed 328D-SSOP20 (was already commented out)
@dbuezas dbuezas marked this pull request as draft April 15, 2023 22:23
@dbuezas
Copy link
Owner Author

dbuezas commented Apr 15, 2023

@seisfeld @wollewald
Your feedback is also welcome :)
If I didn't miss anything, this would be released as v3.0.0

@LaZsolt
Copy link
Collaborator

LaZsolt commented Apr 15, 2023

I'll test the new menu after morning.
Does the divider menu look better this way?

1
1/2
1/4
1/8
1/16
1/32

@dbuezas
Copy link
Owner Author

dbuezas commented Apr 15, 2023

It's also an option. We could use:

  • divider (int or fraction)
  • prescaler (int or fraction)
  • multiplier (with fractions as you suggest)

I just thought that "divider" seems to be what we call it in issues

@dbuezas
Copy link
Owner Author

dbuezas commented Apr 15, 2023

BTW, I tested it with an LQFP48 which has an external 16MHz xtal too, didn't see any issues.

@LaZsolt
Copy link
Collaborator

LaZsolt commented Apr 15, 2023

Prescaler.

@dbuezas
Copy link
Owner Author

dbuezas commented Apr 15, 2023

(updated screenshot to Internal 32MHz)

@dbuezas
Copy link
Owner Author

dbuezas commented Apr 15, 2023

image

This is how it looks with fractions

@dbuezas
Copy link
Owner Author

dbuezas commented Apr 15, 2023

IMO the UI is much easier to understand and configure without the extra boards for each crystal. And the boards.txt is also way easier to follow

@wollewald
Copy link
Contributor

Hi I just tried it. Looks better than before. And I would recommend to keep "clock divider" and not multiplier or prescaler. I think it's best understandable for beginners.
A pedantic comment: If you choose "Clock divider" and take the fraction style, e. g. 1/32, it's not correct. 32 is the divider and not 1/32. Then multiplier would be correct.

lgt8f/boards.txt Outdated Show resolved Hide resolved
lgt8f/boards.txt Outdated Show resolved Hide resolved
lgt8f/boards.txt Outdated Show resolved Hide resolved
@dbuezas dbuezas requested a review from LaZsolt April 16, 2023 09:07
@dbuezas dbuezas marked this pull request as ready for review April 16, 2023 11:36
@dbuezas dbuezas merged commit eb142dc into master Apr 16, 2023
@dbuezas dbuezas deleted the cleanup/boards.txt branch April 16, 2023 11:47
@dbuezas
Copy link
Owner Author

dbuezas commented Apr 16, 2023

Release in progress

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants