Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update to WDT library #299

Merged
merged 5 commits into from
Sep 12, 2023
Merged

Update to WDT library #299

merged 5 commits into from
Sep 12, 2023

Conversation

gpb01
Copy link
Contributor

@gpb01 gpb01 commented Aug 25, 2023

Adds the capability of using the HFRC oscillator for WDT. A usage example has been added.

@gpb01
Update to WDT library
c0193f1 
Adds the capability of using the HFRC oscillator for WDT.
@LaZsolt
Copy link
Collaborator

LaZsolt commented Aug 25, 2023

I had the exact same thought, but you did it.
I suggest some modifications.

@LaZsolt
Update keywords.txt
84b73c0 
Lgtwdt keyword added
@LaZsolt
Update wdt_interrupt_HF.ino
b6ed305 
Line contain "LGTWDT Lgtwdt;" deleted because it is integrated to file WDT.h
@LaZsolt
Update WDT.h
c2c9674 
Defining name Lgtwdt form class LGTWDT integrated to WHT.h
Users do not need to write it into their own program.
@gpb01
Copy link
Contributor Author

gpb01 commented Aug 25, 2023

I suggest some modifications.

Suggestions are always welcome. :-)

Guglielmo

gpb01
gpb01 commented Aug 25, 2023
View reviewed changes
Copy link
Contributor Author

@gpb01 gpb01 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggestions are always welcome. :-)

@LaZsolt
Copy link
Collaborator

LaZsolt commented Aug 25, 2023

I think it's fine.

@gpb01
Copy link
Contributor Author

gpb01 commented Aug 25, 2023

Yes 👍

You can merge the pull-request 😊

@dbuezas
Copy link
Owner

dbuezas commented Aug 26, 2023

Thank you!
What's the effect of using the other oscillator? Longer intervals?

@gpb01
Copy link
Contributor Author

gpb01 commented Aug 26, 2023

What's the effect of using the other oscillator? Longer intervals?

The opposite, getting shorter intervals:

#define WTOH_1MS 0
#define WTOH_2MS 1
#define WTOH_4MS 2
#define WTOH_8MS 3
#define WTOH_16MS 4
#define WTOH_32MS 5
#define WTOH_64MS 6
#define WTOH_128MS 7
#define WTOH_256MS 8
#define WTOH_512MS 9

which can be useful on various occasions, e.g. either when the system clock is 32 MHz, or for porting libraries like FreeRTOS that use the WDT interrupt as a system tick.

Guglielmo

@gpb01
Copy link
Contributor Author

gpb01 commented Sep 12, 2023

PR is waiting ... :-)

Guglielmo

@dbuezas
Copy link
Owner

dbuezas commented Sep 12, 2023

Oh no, sorry for making this wait!

@dbuezas dbuezas merged commit 6a56938 into dbuezas:master Sep 12, 2023
@dbuezas
Copy link
Owner

dbuezas commented Sep 12, 2023

Released https://github.com/dbuezas/lgt8fx/releases/tag/v2.0.7

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@gpb01 @LaZsolt @dbuezas