NullReferenceException when using InjectionFactory to register type #3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Also included in the fix for the NullReferenceException is a fix for the broken psake script - looks like NUnit was updated at some point and with the new version the console-runner is in a separate nuget package. So I added the package and fixed the script to point to the current runner. You may have to get a clean version of the repo to duplicate the issue since it's probably due to the older version of NUnit still sitting in your packages folder. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When using InjectionFactory to register a type the FromType property for the RegisterEventArgs will be null. This causes a NullReferenceException to be thrown. I've added a test to demonstrate the issue. If I can figure out the problem and get all tests to pass I'll submit a pull request for that as well. But I just thought you'd like to have the test anyway.