Fixed undefined this on SeriesChart redraw #1800
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I had the following bug when redrawing a SeriesChart:
```
dc.js:12456 Uncaught TypeError: Cannot read property '_charts' of undefined
at _clearChart (dc.js:12456)
at Array.map (<anonymous>)
at SeriesChart._resetChildren (dc.js:12463)
at SeriesChart.chart (dc.js:12482)
at showUpdatedChart (panel.js:35)
```
The issue is that passing `this._clearChart` to `map` like that makes it unbound, thus the need to bind it again to `this` to clear the issue.
I spent a good time looking for this issue online and have found nothing, so if I'm misguided in any way, let me know, thanks!
Nonetheless, this fix solves correctly my use case.
|
Thanks for the quick answer! Glad to know I could help a bit :) |
|
Released in 4.2.3 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I had the following bug when redrawing a SeriesChart:
The issue is that passing
this._clearCharttomaplike that makes it unbound, thus the need to bind it again tothisto clear the issue.I spent a good time looking for this issue online and have found nothing, so if I'm misguided in any way, let me know, thanks!
Nonetheless, this fix solves correctly my use case.