feat(coordinateGridMixin): useTopXAxis #1816
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gordonwoodhull
requested changes
Mar 1, 2021
There was a problem hiding this comment.
Thanks @aberenyi! Overall the changes look great.
As a matter of policy, we usually don't try to adjust margins automatically. The interaction of features gets really complicated and we would have to devise a strategy (perhaps using flexbox) rather than writing special case logic everywhere.
So for now we leave this in control of the user. In this case it's better to change the example.
Also I found the double ?: confusing so I made a suggestion there.
courtesy of @gordonwoodhull Co-authored-by: Gordon Woodhull <gordon@woodhull.com>
courtesy of @gordonwoodhull Co-authored-by: Gordon Woodhull <gordon@woodhull.com>
|
Rebased and merged; released in 4.2.5 |
|
Thanks @aberenyi! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@gordonwoodhull could you please cast your eye over this?