Only bind pod ports to host when replicas == 1

podman play kube creates a pod per replica and tries to bind all of them to the
same host port. That however can only work when there is one replica as
otherwise multiple pods get bound to the same port on the host.

This fixes containers#16765

Signed-off-by: Dan Čermák <dcermak@suse.com>

pkg/specgen/generate/kube/kube.go

@@ -73,7 +73,12 @@ func ToPodOpt(ctx context.Context, podName string, p entities.PodCreateOptions,
 		}
 		p.Net.AddHosts = hosts
 	}
-	podPorts := getPodPorts(podYAML.Spec.Containers)
+
+	bindToHostPort := true
+	if podYAML.Replicas != nil && *podYAML.Replicas > 1 {
+		bindToHostPort = false
+	}
+	podPorts := getPodPorts(template.Spec.Containers, bindToHostPort)
 	p.Net.PublishPorts = podPorts
 
 	if dnsConfig := template.Spec.DNSConfig; dnsConfig != nil {
@@ -937,14 +942,14 @@ func getContainerResources(container v1.Container) (v1.ResourceRequirements, err
 
 // getPodPorts converts a slice of kube container descriptions to an
 // array of portmapping
-func getPodPorts(containers []v1.Container) []types.PortMapping {
+func getPodPorts(containers []v1.Container, bindToHostPort bool) []types.PortMapping {
 	var infraPorts []types.PortMapping
 	for _, container := range containers {
 		for _, p := range container.Ports {
 			if p.HostPort != 0 && p.ContainerPort == 0 {
 				p.ContainerPort = p.HostPort
 			}
-			if p.HostPort == 0 && p.ContainerPort != 0 {
+			if p.HostPort == 0 && p.ContainerPort != 0 && bindToHostPort {
 				p.HostPort = p.ContainerPort
 			}
 			if p.Protocol == "" {

test/system/700-play.bats

@@ -444,3 +444,31 @@ spec:
     run_podman pod rm -a -f
     run_podman rm -a -f
 }
+
+@test "podman kube play - hostport and replicas" {
+    HOST_PORT=$(random_free_port)
+    echo "
+apiVersion: v1
+kind: Pod
+metadata:
+  labels:
+    app: test
+  name: test_pod
+spec:
+  replicas: 3
+  containers:
+    - name: server
+      image: $IMAGE
+      ports:
+        - name: hostp
+          containerPort: $HOST_PORT
+" > $PODMAN_TMPDIR/testpod.yaml
+
+    run_podman kube play $PODMAN_TMPDIR/testpod.yaml
+    run_podman pod inspect test_pod --format "{{.InfraConfig.PortBindings}}"
+    assert "$output" = "map[]"
+    run_podman kube down $PODMAN_TMPDIR/testpod.yaml
+
+    run_podman pod rm -a -f
+    run_podman rm -a -f
+}