Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add nacl.sign.keyPair.fromSeed #37

Closed
dchest opened this issue Jul 17, 2014 · 1 comment · Fixed by #46
Closed

Add nacl.sign.keyPair.fromSeed #37

dchest opened this issue Jul 17, 2014 · 1 comment · Fixed by #46

Comments

@dchest
Copy link
Owner

dchest commented Jul 17, 2014

This function will return a key pair generated from a seed (which should be random), instead of calling randombytes internally, which is what nacl.sign.keyPair does.

On one hand, there's currently no way to do what this function does without copying half of the library, on the other hand, it complicates code (and makes diff from tweenacl.c not so pretty) for an uncommon use case (which can also be dangerous if you're not careful with producing proper seeds, e.g. from passwords with weak derivation function).

Filed under "maybe".

dchest added a commit that referenced this issue Jul 27, 2014
Allows deriving a new sign key pair deterministically from a 32-byte
seed. Introduces a tiny change to the low-level crypto_sign_keypair():
a new argument that indicates that sk already contains seed bytes;
however crypto_sign_keypair() interface behaves exactly the same as
before if this argument is not truthful (e.g. not set).

Closes #37.
@dchest
Copy link
Owner Author

dchest commented Jul 27, 2014

Discuss @ #46

@dchest dchest closed this as completed Jul 27, 2014
dchest added a commit that referenced this issue Aug 3, 2014
Allows deriving a new sign key pair deterministically from a 32-byte
seed. Introduces a tiny change to the low-level crypto_sign_keypair():
a new argument that indicates that sk already contains seed bytes;
however crypto_sign_keypair() interface behaves exactly the same as
before if this argument is not truthful (e.g. not set).

Closes #37.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant