Implement nacl.sign.keyPair.fromSeed. #46
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allows deriving a new sign key pair deterministically from a 32-byte
seed. Introduces a tiny change to the low-level crypto_sign_keypair():
a new argument that indicates that sk already contains seed bytes;
however crypto_sign_keypair() interface behaves exactly the same as
before if this argument is not truthful (e.g. not set).
Closes #37.
I don't like changing low-level things, even though this change is tiny :( Another way to do this would be to copy
crypto_sign_keypair
intocrypto_sign_seeded_keypair
or something like it, but droppingrandombytes
inside; however while it doesn't change the original implementation, it introduces another 16 lines of useless code. I won't merge this until more thinking.