Skip to content

Commit

Permalink
Disable HTTP timeouts for dcos task exec` requests (#1099)
Browse files Browse the repository at this point in the history
As this command relies on a long-running HTTP connection using chucked
transfer encoding, it is common to have no data to read from the server
for an undefined period of time.

This happens for example when opening a shell session and not typing
anything.

https://jira.mesosphere.com/browse/DCOS_OSS-1827
  • Loading branch information
bamarni authored and klueska committed Nov 14, 2017
1 parent 9b64ecc commit 2f881e9
Showing 1 changed file with 2 additions and 0 deletions.
2 changes: 2 additions & 0 deletions dcos/mesos.py
Expand Up @@ -1302,6 +1302,7 @@ def _launch_nested_container_session(self):
response = http.post(
self.agent_url,
data=json.dumps(message),
timeout=None,
**req_extra_args)

self._process_output_stream(response)
Expand Down Expand Up @@ -1420,6 +1421,7 @@ def _input_streamer():
http.post(
self.agent_url,
data=_input_streamer(),
timeout=None,
**req_extra_args)

def _input_thread(self):
Expand Down

0 comments on commit 2f881e9

Please sign in to comment.