Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable HTTP timeouts for dcos task requests #1099

Merged
merged 1 commit into from Nov 14, 2017

Conversation

bamarni
Copy link
Contributor

@bamarni bamarni commented Nov 10, 2017

As this command relies on a long-running HTTP connection using chuncked transfer encoding, it is common to have no data to read from the server for an undefined period of time.

This happens for example when opening a shell session and not typing anything.

https://jira.mesosphere.com/browse/DCOS_OSS-1827

This problem was introduced in #1052.

As this command relies on a long-running HTTP connection using chucked
transfer encoding, it is common to have no data to read from the server
for an undefined period of time.

This happens for example when opening a shell session and not typing
anything.

https://jira.mesosphere.com/browse/DCOS_OSS-1827
@bamarni bamarni requested a review from klueska November 10, 2017 13:38
@bamarni
Copy link
Contributor Author

bamarni commented Nov 10, 2017

run linux integration tests

@klueska
Copy link
Contributor

klueska commented Nov 14, 2017

run windows integration tests

@klueska
Copy link
Contributor

klueska commented Nov 14, 2017

run mac integration tests

Copy link
Contributor

@klueska klueska left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We need to add a soak-cluster test out of band of this in order to test this in a long running manner. We should merge it now, regardless, but once we have the soak cluster test PR we should link it here.

@klueska klueska merged commit 2f881e9 into dcos:master Nov 14, 2017
bamarni added a commit that referenced this pull request Nov 23, 2017
As this command relies on a long-running HTTP connection using chucked
transfer encoding, it is common to have no data to read from the server
for an undefined period of time.

This happens for example when opening a shell session and not typing
anything.

https://jira.mesosphere.com/browse/DCOS_OSS-1827
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants