Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Failed to start child #26

Merged
merged 2 commits into from
Jan 8, 2018
Merged

Failed to start child #26

merged 2 commits into from
Jan 8, 2018

Conversation

@urbanserj urbanserj force-pushed the urbanserj/failed_to_start_child branch from 12adefe to 12526cb Compare January 4, 2018 20:18
@codecov
Copy link

codecov bot commented Jan 4, 2018

Codecov Report

Merging #26 into master will increase coverage by 0.27%.
The diff coverage is 88.63%.

Impacted file tree graph

@@            Coverage Diff            @@
##           master     #26      +/-   ##
=========================================
+ Coverage   66.82%   67.1%   +0.27%     
=========================================
  Files          46      46              
  Lines        2734    2745      +11     
=========================================
+ Hits         1827    1842      +15     
+ Misses        907     903       -4
Impacted Files Coverage Δ
apps/dcos_dns/src/dcos_dns_listener.erl 47.45% <0%> (-1.67%) ⬇️
...os_overlay/src/dcos_overlay_lashup_kv_listener.erl 77.41% <100%> (+0.37%) ⬆️
apps/dcos_dns/src/dcos_dns_zk_record_server.erl 76.74% <100%> (+1.13%) ⬆️
...ps/dcos_l4lb/src/dcos_l4lb_lashup_vip_listener.erl 91.15% <100%> (+0.03%) ⬆️
apps/dcos_overlay/src/dcos_overlay_poller.erl 76.52% <100%> (+0.41%) ⬆️
apps/dcos_l4lb/src/dcos_l4lb_mesos_poller.erl 90.73% <100%> (+0.07%) ⬆️
apps/dcos_l4lb/src/dcos_l4lb_mgr.erl 68.02% <100%> (-0.47%) ⬇️
apps/dcos_dns/src/dcos_dns_handler_fsm.erl 73.1% <0%> (+4.82%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e247ad8...12526cb. Read the comment docs.

@urbanserj urbanserj merged commit 53d4d7c into master Jan 8, 2018
@urbanserj urbanserj deleted the urbanserj/failed_to_start_child branch January 8, 2018 21:01
unai-ttxu pushed a commit to unai-ttxu/dcos-net that referenced this pull request Feb 3, 2020
Return {shutdown, Reason} to avoid Error Logger throwing stuff to con…
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants