-
Notifications
You must be signed in to change notification settings - Fork 81
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: remove svg-sprite dependency #3747
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1 task
juliangieseke
previously approved these changes
Mar 25, 2019
GeorgiSTodorov
previously approved these changes
Mar 26, 2019
brandonc
previously approved these changes
Apr 1, 2019
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This seems straightforward.
mperrotti
dismissed stale reviews from brandonc, GeorgiSTodorov, and juliangieseke
via
April 8, 2019 21:12
de33f75
mperrotti
force-pushed
the
mp/chore/remove-svg-sprite
branch
from
April 8, 2019 21:12
096e146
to
de33f75
Compare
Sorry @brandonc and @GeorgiSTodorov - I rebased with master and dismissed your reviews. Mind updating? :) |
brandonc
approved these changes
Apr 8, 2019
GeorgiSTodorov
approved these changes
Apr 9, 2019
nLight
approved these changes
Apr 9, 2019
🎉 This PR is included in version 2.78.3 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Testing
Trade-offs
Dependencies
Screenshots