Fix build validation when variant packages aren't in bootstrap #1318
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This repo has @mesosphere-mergebot integration. You can interact with the following commands. |
|
Here's proof that the |
This prevents an exception from being raised when a bootstrap package list doesn't include a package listed in a treeinfo's package variants. A treeinfo with bootstrap_package_list is expected to produce a bootstrap tarball containing a subset of all cluster packages, so it's not necessarily an error if a package variant isn't present in it.
branden
force-pushed
the
package-variant-validation
branch
from
30408d5
to
ec228bc
Compare
|
@BenWhitehead @orsenthil Ready for review. |
orsenthil
pushed a commit
to mesosphere/dcos
that referenced
this pull request
Mar 3, 2017
Merged
orsenthil
pushed a commit
to mesosphere/dcos
that referenced
this pull request
Mar 4, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
High Level Description
This prevents an exception from being raised when a treeinfo's bootstrap package list doesn't pull in a package listed in the treeinfo's package variants. A treeinfo with
bootstrap_package_listis expected to produce a bootstrap tarball containing a subset of its complete set of packages, so it's not necessarily an error if a package variant isn't present within it.Related Issues
Checklist for all PR's
Checklist for component/package updates:
If you are changing components or packages in DC/OS (e.g. you are bumping the sha or ref of anything underneath
packages), then in addition to the above please also include: