Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set tcp_be_liberal as part of Minuteman initialization #18

Merged
merged 1 commit into from
May 17, 2016

Conversation

sargun
Copy link
Contributor

@sargun sargun commented Apr 25, 2016

No description provided.

@sargun
Copy link
Contributor Author

sargun commented Apr 25, 2016

@spahl @cmaloney

@cmaloney
Copy link
Contributor

We don't own these settings globally / don't own sysctl settings. For AWS / CloudFormation clusters we can / should set these (in a way that is persistent across reboots and the like). The service cannot set them however.

@sargun
Copy link
Contributor Author

sargun commented Apr 25, 2016

Why can't we take them over? I don't think that people will actually set this setting based on the documentation, and they'll see issues when they're hairpinning traffic between Docker containers. Given that DC/OS runs on edge systems, and you're typically not using conntrack for any kind of security / hole-punch limiting, it seems like a fairly reasonable, conservative option.

The kernel gets confused because it has an earlier conntrack entry for this traffic since it creates one before it gets from the Docker container to the forwarding table.

If you think that we should avoid touching this, can you create a PR to set this in the AWS / Cloudformation images, and I'll do the PR so it gets into ACS?

@lingmann
Copy link
Contributor

It sounds like this should be replaced with:

  1. A pre-flight check to validate that sysctl is configured appropriately for minuteman
  2. An update to the Azure templates to configure sysctl
  3. An update to the AWS templates to configure sysctl

@lingmann
Copy link
Contributor

lingmann commented May 6, 2016

Per some conversations with @spahl and @sargun I think we are going to claim ownership of certain default sysctl settings. People will be able to override, but at their own risk. Do we have enough consensus here to move forward with the patch as is @cmaloney?

@spahl
Copy link
Contributor

spahl commented May 6, 2016

+1

@spahl spahl mentioned this pull request May 16, 2016
@cmaloney cmaloney merged commit 5dd74ce into dcos:master May 17, 2016
@bajohns
Copy link

bajohns commented May 19, 2016

Thanks for this patch - this solved a number of vexing connection issues from the MySQL driver.

@damhau
Copy link

damhau commented Jul 25, 2016

This also solved my problem with Kibana, it was unable to connect to Elasticsearch.
I mention it so that google can pick this answer if somebody else has the same problem.

jcortejoso pushed a commit to jcortejoso/dcos that referenced this pull request Oct 3, 2016
[PAAS-242] Fix artifact path
jcortejoso pushed a commit to jcortejoso/dcos that referenced this pull request Oct 3, 2016
[PAAS-242] Adding deploy stage

Fix artifact path (dcos#18)

[PAAS-242] Fix artifact path

Fix s3upload call (dcos#19)

[PAAS-242] Fix s3upload call

Add -x to s3upload script for tracing (dcos#20)

[PAAS-242] Add -x to s3upload script for tracing

Fix s3upload credentials name (dcos#21)

[PAAS-242] Fix s3upload credentials name

Fix try_fetch methods to use all storage providers defined in yaml (dcos#22)

[PAAS-204] Fix try_fetch methods to use all storage providers defined in yaml

[PAAS-242] Change version and naming convention (dcos#23)

* Change version and naming convention

* Add code quality step

* Add permissions to code quality script

* Fix separator in Makefile

Add permissions for public download from s3 (dcos#24)
sergiimatusEPAM pushed a commit to sergiimatus/dcos that referenced this pull request Dec 3, 2019
Bump. from Dcos4windows to comply with dcos master PR
d2iq-mergebot pushed a commit that referenced this pull request Jan 22, 2020
Update master branch from dcos/master
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants