Admin Router: Minimizing software version information reported by the AR [1.10]

[vespian]

Just a backport of #2154

Jira issue: https://jira.mesosphere.com/browse/DCOS-19765 Admin Router: port software version scrubbing from DCOS-19534 to 1.10

[d2iq-mergebot]

This repo has @mesosphere-mergebot integration. You can interact with the following commands.

@mesosphere-mergebot override-status  
@mesosphere-mergebot pr-status-checks  
@mesosphere-mergebot ship_it_label_status_check  
@mesosphere-mergebot merge-it  
@mesosphere-mergebot bump-ee  
@mesosphere-mergebot label [Request For Comment |Work In Progress |Ready For Review |Holding |Ship It] 

• PR creators can apply one of [Ready For Review |Work In Progress]. Owners can apply any label.

[vespian]

@mesosphere-mergebot bump-ee

[d2iq-mergebot]

Enterprise Bump PR: mesosphere/dcos-enterprise/pull/1998

[vespian]

@mesosphere-mergebot override-status teamcity/dcos/test/docker/smoke https://jira.mesosphere.com/browse/DCOS_OSS-1457

[d2iq-mergebot]

@vespian, an owner other than the PR creator needs to issue that command.

[jgehrcke]

@mesosphere-mergebot override-status teamcity/dcos/test/docker/smoke DCOS_OSS-1457

[vespian]

@mesosphere-mergebot label ready for review

[adamtheturtle]

@vespian Please could you explain the differences between this and https://github.com/dcos/dcos/pull/2154/files?

For example, there is a test there that is there but not here:

   - tests:
 +      are_response_headers_ok:
 +        nocaching_headers_are_sent: skip
 +        test_paths:
 +          - /system/v1/leader/mesos/foo/bar?key=value&var=num
 +          - /system/v1/leader/marathon/foo/bar?key=value&var=num

[vespian]

@mesosphere-mergebot bump-ee

[d2iq-mergebot]

Enterprise Bump mesosphere/dcos-enterprise/pull/1998 updated.

[vespian]

@adamtheturtle I added the missing test.

I have gone through the PRs (both EE and Open) and all other tests seem OK. It is impossible to cherry-pick the 1.11 changes 1:1 as:

• in Open, the /service/metronome/ test was introduced in 1.11 dev cycle
• in EE, the /vault endpoint tests was replaced by /cockroachdb endpoint tests

Please have another look modulo CI and thank you for yet another thorough review :)

[vespian]

@mesosphere-mergebot override-status teamcity/dcos/test/aws/onprem/static https://jira.mesosphere.com/browse/DCOS-19542

[d2iq-mergebot]

@vespian, an owner other than the PR creator needs to issue that command.

[amitaekbote]

@mesosphere-mergebot override-status teamcity/dcos/test/aws/onprem/static https://jira.mesosphere.com/browse/DCOS-19542

[jgehrcke]

🚀

[vespian]

@mesosphere-mergebot ship_it_label_status_check

[vespian]

EE PR is all-green/has ship it, Mergebot applied Ship-it to this PR, but the mergebot/enterprise/build-status/aggregate is still yellow - I do not know why :(

CC @orsenthil

[orsenthil]

@vespian - this is events getting lost between github services. If this happens again, please go to EE side, a re-run the tox or a simple status check again. The aggregate will be sent again.