-
Notifications
You must be signed in to change notification settings - Fork 486
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bump dcos-test-utils #2356
Bump dcos-test-utils #2356
Conversation
This bump will introduce more verbose logging for metronome tests.
This repo has @mesosphere-mergebot integration. You can interact with the following commands.
|
@mesosphere-mergebot label Ready For Review |
I cannot assign reviewers. @mellenburg @adamtheturtle can you maybe review please? |
@mesosphere-mergebot bump-ee |
Enterprise Bump PR: mesosphere/dcos-enterprise/pull/2117 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you @alenkacz.
Please fill in the "Checklist for component/package updates" part of the description.
However, trusting that this will be all good, I have attempted to create a bump PR for DC/OS Enterprise - see my previous comment.
I approve this change modulo test failures. That is, if you see any test failures, please document them here and in JIRA. Failures can be overridden by "owners" of this repository.
Please also make clear on JIRA that this PR exists and which other versions of DC/OS you plan to apply this to.
👋 This PR has been inactive for 3 days. Please review the status checks to see what needs to be done to move it forward or change the label to Work in Progress. Thank you! |
@adamtheturtle I think the test failure is not related to this bump but I did not found any open ticket regarding this tests being flaky (but many closed ones...) I don't think I need to fill anything to the ticket, there is git-jira integration, so this PR will be linked to that ticket once it gets merged if containing the ticket number. And I am fine with this being just in master for now (considering how painful it is to merge something to DC/OS :) and how much babysitting it required). |
I found https://jira.mesosphere.com/browse/DCOS_OSS-2115 which I believe is the relevant, open issue. Please can an owner override
You need to do the following:
If this call is going to be made, I'd like @mellenburg's approval as so far he has worked hard to keep them all in sync. |
@mesosphere-mergebot override-status teamcity/dcos/test/aws/cloudformation/simple DCOS_OSS-2115 |
High-level description
This bump will introduce more verbose logging for metronome tests.
Corresponding DC/OS tickets (obligatory)
These DC/OS JIRA ticket(s) must be updated (ideally closed) in the moment this PR lands:
Checklist for all PRs
Checklist for component/package updates:
If you are changing components or packages in DC/OS (e.g. you are bumping the sha or ref of anything underneath
packages
), then in addition to the above please also include: