Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump dcos-test-utils #2356

Merged
merged 1 commit into from
Feb 6, 2018
Merged

Bump dcos-test-utils #2356

merged 1 commit into from
Feb 6, 2018

Conversation

alenkacz
Copy link
Contributor

@alenkacz alenkacz commented Jan 24, 2018

High-level description

This bump will introduce more verbose logging for metronome tests.

Corresponding DC/OS tickets (obligatory)

These DC/OS JIRA ticket(s) must be updated (ideally closed) in the moment this PR lands:

  • DCOS-20444 Investigate EE-Integration-Test/E2E CI run error in dcos-enterprise/pull/2092. Failure in _wait_for_metronome

Checklist for all PRs

Checklist for component/package updates:

If you are changing components or packages in DC/OS (e.g. you are bumping the sha or ref of anything underneath packages), then in addition to the above please also include:

This bump will introduce more verbose logging for metronome tests.
@d2iq-mergebot
Copy link
Collaborator

This repo has @mesosphere-mergebot integration. You can interact with the following commands.

@mesosphere-mergebot label [Holding |Work In Progress |Ready For Review |Request For Comment |Ship It] 
@mesosphere-mergebot override-status  
@mesosphere-mergebot merge-it  
@mesosphere-mergebot pr-status-checks  
@mesosphere-mergebot ship_it_label_status_check  
@mesosphere-mergebot bump-ee  
  • PR creators can apply one of [Ready For Review |Work In Progress]. Owners can apply any label.

@alenkacz
Copy link
Contributor Author

@mesosphere-mergebot label Ready For Review

@alenkacz
Copy link
Contributor Author

I cannot assign reviewers. @mellenburg @adamtheturtle can you maybe review please?

@adamtheturtle
Copy link
Contributor

@mesosphere-mergebot bump-ee

@d2iq-mergebot
Copy link
Collaborator

Enterprise Bump PR: mesosphere/dcos-enterprise/pull/2117

Copy link
Contributor

@adamtheturtle adamtheturtle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @alenkacz.

Please fill in the "Checklist for component/package updates" part of the description.

However, trusting that this will be all good, I have attempted to create a bump PR for DC/OS Enterprise - see my previous comment.

I approve this change modulo test failures. That is, if you see any test failures, please document them here and in JIRA. Failures can be overridden by "owners" of this repository.

Please also make clear on JIRA that this PR exists and which other versions of DC/OS you plan to apply this to.

@d2iq-mergebot
Copy link
Collaborator

👋 This PR has been inactive for 3 days. Please review the status checks to see what needs to be done to move it forward or change the label to Work in Progress. Thank you!

@alenkacz
Copy link
Contributor Author

@adamtheturtle I think the test failure is not related to this bump but I did not found any open ticket regarding this tests being flaky (but many closed ones...)

I don't think I need to fill anything to the ticket, there is git-jira integration, so this PR will be linked to that ticket once it gets merged if containing the ticket number.

And I am fine with this being just in master for now (considering how painful it is to merge something to DC/OS :) and how much babysitting it required).

@adamtheturtle
Copy link
Contributor

adamtheturtle commented Jan 29, 2018

@adamtheturtle I think the test failure is not related to this bump but I did not found any open ticket regarding this tests being flaky (but many closed ones...)

I found https://jira.mesosphere.com/browse/DCOS_OSS-2115 which I believe is the relevant, open issue.

Please can an owner override teamcity/dcos/test/aws/cloudformation/simple for https://jira.mesosphere.com/browse/DCOS_OSS-2115. cc @senthil.

I don't think I need to fill anything to the ticket, there is git-jira integration, so this PR will be linked to that ticket once it gets merged if containing the ticket number.

You need to do the following:

  1. Link to the change log as per:

Change log from the last version integrated (this should be a link to commits for easy verification and review): example

  1. Link to the test-utils test results

Test Results: [link to CI job test results for component]

  1. I don't think that test-utils has a code coverage report, so "Code Coverage (if available): [link to code coverage report]" is probably not relevant.

And I am fine with this being just in master for now (considering how painful it is to merge something to DC/OS :) and how much babysitting it required).

If this call is going to be made, I'd like @mellenburg's approval as so far he has worked hard to keep them all in sync.

@mellenburg
Copy link

@mesosphere-mergebot override-status teamcity/dcos/test/aws/cloudformation/simple DCOS_OSS-2115

orsenthil pushed a commit to mesosphere/dcos that referenced this pull request Feb 5, 2018
@d2iq-mergebot d2iq-mergebot merged commit 7181cf4 into dcos:master Feb 6, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants