Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix flask-compress import #2829

Merged
merged 1 commit into from
May 2, 2018
Merged

Fix flask-compress import #2829

merged 1 commit into from
May 2, 2018

Conversation

branden
Copy link
Contributor

@branden branden commented Apr 30, 2018

High-level description

flask.ext.compress moved to flask_compress. This updates the import accordingly.

Corresponding DC/OS tickets (obligatory)

These DC/OS JIRA ticket(s) must be updated (ideally closed) in the moment this PR lands:

Checklist for all PRs

  • Added a comprehensible changelog entry to CHANGES.md or explain why this is not a user-facing change: This fixes an import, no other change is intended.
  • Included a test which will fail if code is reverted but test is not. If there is no test please explain here: This fixes the unit tests for dcos-history.
  • Read the DC/OS contributing guidelines
  • Followed relevant code rules Rules for Packages and Systemd

Checklist for component/package updates:

If you are changing components or packages in DC/OS (e.g. you are bumping the sha or ref of anything underneath packages), then in addition to the above please also include:

  • Change log from the last version integrated (this should be a link to commits for easy verification and review): example
  • Test Results: [link to CI job test results for component]
  • Code Coverage (if available): [link to code coverage report]

@branden
Fix flask-compress import
378d0b4 
flask.ext.compress moved to flask_compress.
@d2iq-mergebot
Copy link
Collaborator

This repo has @mesosphere-mergebot integration. You can interact with the following commands.

@mesosphere-mergebot merge-it  
@mesosphere-mergebot override-status  
@mesosphere-mergebot bump-ee  
@mesosphere-mergebot label [Work In Progress |Holding |Request For Comment |Ship It |Ready For Review]
  • PR creators can apply one of [Ready For Review |Work In Progress]. Owners can apply any label.

@branden
Copy link
Contributor Author

branden commented Apr 30, 2018

@mesosphere-mergebot bump-ee

1 similar comment
@branden
Copy link
Contributor Author

branden commented Apr 30, 2018

@mesosphere-mergebot bump-ee

@d2iq-mergebot
Copy link
Collaborator

Enterprise Bump PR: mesosphere/dcos-enterprise/pull/2692

@branden
Copy link
Contributor Author

branden commented Apr 30, 2018

@mesosphere-mergebot label ready for review

This was referenced Apr 30, 2018
Merged
Merged
Merged
@orsenthil
Copy link
Contributor

@mesosphere-mergebot label ship-it

@orsenthil
Copy link
Contributor

@mesosphere-mergebot merge-it

@d2iq-mergebot
Copy link
Collaborator

Enterprise Bump PR mesosphere/dcos-enterprise/pull/2692, and the current PR #2829 are now merged.

@d2iq-mergebot d2iq-mergebot merged commit 378d0b4 into dcos:master May 2, 2018
@branden branden deleted the flask-compress-import branch May 3, 2018 22:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@urbanserj urbanserj urbanserj approved these changes

@orsenthil orsenthil orsenthil approved these changes

Assignees
No one assigned
Labels
Ship It
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@branden @d2iq-mergebot @orsenthil @urbanserj @mesosphere-mergebot-dev