Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[1.12] Bump dcos-net #3632

Merged
merged 1 commit into from
Oct 18, 2018
Merged

Conversation

urbanserj
Copy link
Contributor

@urbanserj urbanserj commented Oct 16, 2018

High-level description

Bump dcos-net.

Corresponding DC/OS tickets (obligatory)

These DC/OS JIRA ticket(s) must be updated (ideally closed) in the moment this PR lands:

  • DCOS_OSS-4320 dcos-dns incorrectly deletes records in PODs when one container exits.
  • DCOS_OSS-4337 [dcos-net] DNS issue due to non unique task Id

Related tickets (optional)

Other tickets related to this change:

Checklist for all PRs

  • Added a comprehensible changelog entry to CHANGES.md or explain why this is not a user-facing change: all bugs were introduced and fixed in 1.12 branch
  • Included a test which will fail if code is reverted but test is not. If there is no test please explain here: none
  • Read the DC/OS contributing guidelines
  • Followed relevant code rules Rules for Packages and Systemd

Checklist for component/package updates:

If you are changing components or packages in DC/OS (e.g. you are bumping the sha or ref of anything underneath packages), then in addition to the above please also include:

  • Change log from the last version integrated (this should be a link to commits for easy verification and review): example
  • Test Results: [link to CI job test results for component]
  • Code Coverage (if available): [link to code coverage report]

dcos/dcos-net@d8dd432...b028145
dcos/dcos-net#92
dcos/dcos-net#94
dcos/dcos-net#95
dcos/dcos-net#96
https://circleci.com/gh/dcos/dcos-net/722
https://codecov.io/github/dcos/dcos-net/commit/b02814510c1d4686b7055c4f70f44410bc3892c9


PLEASE FILL IN THE TEMPLATE ABOVE / DO NOT REMOVE ANY SECTIONS ABOVE THIS LINE

Instructions and review process

What is the review process and when will my changes land?

All PRs require 2 approvals using GitHub's pull request reviews.

Reviewers should be:

  • Developers who understand the code being modified.
  • Developers responsible for code that interacts with or depends on the code being modified.

It is best to proactively ask for 2 reviews by @mentioning the candidate reviewers in the PR comments area. The responsibility is on the developer submitting the PR to follow-up with reviewers and make sure a PR is reviewed in a timely manner. Once a PR has 2 ship-it's, no red reviews, and all tests are green it will be included in the next train.

@d2iq-mergebot
Copy link
Collaborator

This repo has @mesosphere-mergebot integration. You can interact with the following commands.

@mesosphere-mergebot sync  
@mesosphere-mergebot override-status pr-status-check jira-url 
@mesosphere-mergebot label [Holding |Work In Progress |Ready For Review |Request For Comment |Ship It] 
@mesosphere-mergebot bump-ee  
@mesosphere-mergebot merge-it  
  • PR creators can apply one of [Ready For Review |Work In Progress]. Owners can apply any label.

@urbanserj
Copy link
Contributor Author

@mesosphere-mergebot bump-ee

@d2iq-mergebot
Copy link
Collaborator

Enterprise Bump PR: mesosphere/dcos-enterprise/pull/3653

@urbanserj
Copy link
Contributor Author

@mesosphere-mergebot label [Ready For Review]

@urbanserj
Copy link
Contributor Author

@mesosphere-mergebot bump-ee

@d2iq-mergebot
Copy link
Collaborator

Enterprise Bump mesosphere/dcos-enterprise/pull/3653 updated.

Copy link
Contributor

@mainred mainred left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

d2iq-mergebot added a commit to mesosphere/dcos that referenced this pull request Oct 17, 2018
@d2iq-mergebot d2iq-mergebot merged commit bfe2bfb into dcos:1.12 Oct 18, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants