-
Notifications
You must be signed in to change notification settings - Fork 486
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[1.12] Bump dcos-net #3632
[1.12] Bump dcos-net #3632
Conversation
This repo has @mesosphere-mergebot integration. You can interact with the following commands.
|
@mesosphere-mergebot bump-ee |
Enterprise Bump PR: mesosphere/dcos-enterprise/pull/3653 |
@mesosphere-mergebot label [Ready For Review] |
5b96c42
to
bfe2bfb
Compare
@mesosphere-mergebot bump-ee |
Enterprise Bump mesosphere/dcos-enterprise/pull/3653 updated. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
High-level description
Bump dcos-net.
Corresponding DC/OS tickets (obligatory)
These DC/OS JIRA ticket(s) must be updated (ideally closed) in the moment this PR lands:
Related tickets (optional)
Other tickets related to this change:
Checklist for all PRs
CHANGES.md
or explain why this is not a user-facing change: all bugs were introduced and fixed in 1.12 branchChecklist for component/package updates:
If you are changing components or packages in DC/OS (e.g. you are bumping the sha or ref of anything underneath
packages
), then in addition to the above please also include:dcos/dcos-net@d8dd432...b028145
dcos/dcos-net#92
dcos/dcos-net#94
dcos/dcos-net#95
dcos/dcos-net#96
https://circleci.com/gh/dcos/dcos-net/722
https://codecov.io/github/dcos/dcos-net/commit/b02814510c1d4686b7055c4f70f44410bc3892c9
PLEASE FILL IN THE TEMPLATE ABOVE / DO NOT REMOVE ANY SECTIONS ABOVE THIS LINE
Instructions and review process
What is the review process and when will my changes land?
All PRs require 2 approvals using GitHub's pull request reviews.
Reviewers should be:
It is best to proactively ask for 2 reviews by @mentioning the candidate reviewers in the PR comments area. The responsibility is on the developer submitting the PR to follow-up with reviewers and make sure a PR is reviewed in a timely manner. Once a PR has 2 ship-it's, no red reviews, and all tests are green it will be included in the next train.