Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Get rid of Kamon #252

Merged
merged 2 commits into from Aug 28, 2018
Merged

Get rid of Kamon #252

merged 2 commits into from Aug 28, 2018

Conversation

alenkacz
Copy link
Contributor

JIRA issues: DCOS-40531

Copy link
Contributor

@kensipe kensipe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LOVE IT!!!

case Left(kamonSnapshot) => Json.stringify(Json.toJson(Raml.toRaml(kamonSnapshot)))
case Left(_) =>
// Kamon snapshot
throw new IllegalArgumentException("Only dropwizard format is supported, cannot render metrics from Kamon snapshot. Make sure your metrics are configured correctly.")

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

dropwizard -> Dropwizard

@ichernetsky ichernetsky merged commit 6ff4075 into master Aug 28, 2018
@ichernetsky ichernetsky deleted the av/drop-kamon branch August 28, 2018 17:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants