Execute dependent job when all dependencies finished. #382
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Summary: tbd JIRA issues: DCOS_OSS-5974
jeschkies
commented
Jul 30, 2020
| if (dependenciesState.shouldTriggerJob(lastSuccessfulRun)) { | ||
| log.info(s"Start next run of job ${spec.id}, all parents finished successfully") | ||
| runService.startJobRun(initSpec).pipeTo(self) | ||
| context.become(running) |
There was a problem hiding this comment.
I told @pierrebeitz already what limitation we have with this.
First, I think we need to handle the result of startJobRun. It stands to question whether we need another receive method for that.
Second and this is more important, I saw job runs triggered each time there was an update. Imagine C run five seconds depends on A and B. B is run every ten seconds but A every ten millis. This would trigger C multiple times.
A way to avoid this is to save the lastCreatedAt for C and use this as well to check whether we already scheduled a run for C or not. I will create a follow up as a proposal.
| class JobSpecDependencyActor(initSpec: JobSpec, runService: JobRunService) extends Actor with Stash with ActorLogging { | ||
|
|
||
| private[impl] var spec = initSpec | ||
| private[impl] var lastSuccessfulRun: Instant = Instant.MIN |
There was a problem hiding this comment.
Should load the last job run as a failover pattern?
kaiwalyajoshi
approved these changes
Jul 31, 2020
jeschkies
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
This the business logic of MIP 0008 "Jobs with Dependencies". We had an actor analog
to the
JobSpecSchedulerActor. This new actor subscribes to all job run events and updatesan internal state. Once all parents have a successful run that is new than the child run we
trigger new job execution.
JIRA issues: DCOS_OSS-5974