Conversation
✅ Build cadquery 1.0.7 completed (commit 47ea9cd18b by @adam-urbanczyk) |
Codecov Report
@@ Coverage Diff @@
## master #249 +/- ##
=========================================
Coverage ? 92.73%
=========================================
Files ? 10
Lines ? 2174
Branches ? 0
=========================================
Hits ? 2016
Misses ? 158
Partials ? 0 Continue to review full report at Codecov.
|
@adam-urbanczyk Does something need to be done on the Coveralls website account, or will merging this PR take care of everything? |
❌ Build cadquery 1.0.10 failed (commit 47ea9cd18b by @adam-urbanczyk) |
✅ Build cadquery 1.0.11 completed (commit 405a6cf311 by @adam-urbanczyk) |
@adam-urbanczyk I didnt add this project to codecov. Is this ready to merge? @jpmlt when this is merged, can you pull master onto your branch and re-push? I think it will allow your sweep feature to pass the builds also. |
Yes, it is ready.
…On Sun, Apr 8, 2018, 11:15 PM Dave Cowden ***@***.***> wrote:
@adam-urbanczyk <https://github.com/adam-urbanczyk> I didnt add this
project to codecov. Is this ready to merge?
@jpmlt <https://github.com/jpmlt> when this is merged, can you pull
master onto your branch and re-push? I think it will allow your sweep
feature to pass the builds also.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#249 (comment)>, or mute
the thread
<https://github.com/notifications/unsubscribe-auth/ANVXYiqeNBzRk5W4sQP0IC00vv6QBpcQks5tmn3agaJpZM4TFuQa>
.
|
Why is the Appveyor version 1.0.x instead of the CadQuery version of 1.1.x? Is there some significance to that? |
@jmwright I cannot find it. Where do you see 1.0.x? |
@adam-urbanczyk in all the AppVeyorBot posts on this issue. |
I think this is just build numbering convention (not sure what is the rationale though): https://ci.appveyor.com/project/jmwright/cadquery/history In the log I see this (1.1.0): |
update from last version dcowden#249
It looks like codecov merges coverages nicely. Would you agree to at least add it to coveralls?