Skip to content
This repository has been archived by the owner on Feb 9, 2021. It is now read-only.

Added codecov #249

Merged
merged 7 commits into from Apr 9, 2018
Merged

Added codecov #249

merged 7 commits into from Apr 9, 2018

Conversation

adam-urbanczyk
Copy link
Contributor

It looks like codecov merges coverages nicely. Would you agree to at least add it to coveralls?

@coveralls
Copy link

coveralls commented Apr 3, 2018

Coverage Status

Coverage remained the same at 92.134% when pulling c82aaed on adam-urbanczyk:master into 66054b0 on dcowden:master.

@AppVeyorBot
Copy link

@codecov-io
Copy link

codecov-io commented Apr 3, 2018

Codecov Report

❗ No coverage uploaded for pull request base (master@66054b0). Click here to learn what that means.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             master     #249   +/-   ##
=========================================
  Coverage          ?   92.73%           
=========================================
  Files             ?       10           
  Lines             ?     2174           
  Branches          ?        0           
=========================================
  Hits              ?     2016           
  Misses            ?      158           
  Partials          ?        0

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 66054b0...c82aaed. Read the comment docs.

@jmwright
Copy link
Collaborator

jmwright commented Apr 3, 2018

@adam-urbanczyk Does something need to be done on the Coveralls website account, or will merging this PR take care of everything?

@adam-urbanczyk
Copy link
Contributor Author

@jmwright one needs to add this project to codecov (no special configuration needed)
@dcowden did you by any chance already do that?

@AppVeyorBot
Copy link

@AppVeyorBot
Copy link

@dcowden
Copy link
Owner

dcowden commented Apr 8, 2018

@adam-urbanczyk I didnt add this project to codecov. Is this ready to merge?

@jpmlt when this is merged, can you pull master onto your branch and re-push? I think it will allow your sweep feature to pass the builds also.

@adam-urbanczyk
Copy link
Contributor Author

adam-urbanczyk commented Apr 9, 2018 via email

@dcowden dcowden merged commit 980ca90 into dcowden:master Apr 9, 2018
@jmwright
Copy link
Collaborator

jmwright commented Apr 9, 2018

Why is the Appveyor version 1.0.x instead of the CadQuery version of 1.1.x? Is there some significance to that?

@adam-urbanczyk
Copy link
Contributor Author

@jmwright I cannot find it. Where do you see 1.0.x?

@jmwright
Copy link
Collaborator

jmwright commented Apr 9, 2018

@adam-urbanczyk in all the AppVeyorBot posts on this issue.

@adam-urbanczyk
Copy link
Contributor Author

I think this is just build numbering convention (not sure what is the rationale though): https://ci.appveyor.com/project/jmwright/cadquery/history

In the log I see this (1.1.0):
https://ci.appveyor.com/project/jmwright/cadquery/build/1.0.11#L313

jpmlt added a commit to jpmlt/cadquery that referenced this pull request Apr 9, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants