Skip to content
This repository has been archived by the owner on Feb 9, 2021. It is now read-only.

Update sweep function in cq.py add test case and example #251

Merged
merged 2 commits into from
Apr 10, 2018

Conversation

jpmlt
Copy link
Contributor

@jpmlt jpmlt commented Apr 8, 2018

Update sweep function to allow to create only one solid swept along path with shape following the list of wires on the chain.
Update testcase by adding new test to use new functionality : testSweepAlongListOfWires
Add new example Ex034
JPM

@AppVeyorBot
Copy link

Build cadquery 1.0.8 failed (commit 227ee95323 by @jpmlt)

@coveralls
Copy link

coveralls commented Apr 8, 2018

Coverage Status

Coverage increased (+0.1%) to 92.304% when pulling d40d8f4 on jpmlt:multi-sweep-branch into 980ca90 on dcowden:master.

@dcowden
Copy link
Owner

dcowden commented Apr 8, 2018

@jpmlt thanks for the contribution!

It looks like the python3 build failed due to missing conda package.

PackagesNotFoundError: The following packages are not available from current channels:

  • freecad==0.17=py36_11

I'll have a look at that when i get the chance.

@dcowden
Copy link
Owner

dcowden commented Apr 8, 2018

@jmwright you are more familiar with sweep-- what do you think about this PR?
It has an example and a working test so its ok with me!

@AppVeyorBot
Copy link

Build cadquery 1.0.9 failed (commit cee6194c46 by @jpmlt)

@jmwright
Copy link
Collaborator

jmwright commented Apr 8, 2018

@dcowden I won't get to check it until tonight. I'm curious if it fixes #186 as well.

@adam-urbanczyk Any thoughts on the missing FreeCAD Conda package?

@adam-urbanczyk
Copy link
Contributor

@dcowden @jmwright weird I triggered the appveyor build again to be sure, but still failes on the package not available. The funny thing is that I see it still being there:

https://anaconda.org/freecad/freecad/files/modal/info/5ab4b7bce586bb11eae249c3

I will try to reproduce this problem on a local PC.

@AppVeyorBot
Copy link

Build cadquery 1.0.12 failed (commit cee6194c46 by @jpmlt)

@AppVeyorBot
Copy link

Build cadquery 1.0.13 failed (commit cee6194c46 by @jpmlt)

@adam-urbanczyk
Copy link
Contributor

Looks like I fixed it (Cf. #249). I think long term solution would be to make our own conda channel with all dependencies.

@dcowden
Copy link
Owner

dcowden commented Apr 9, 2018

@jpmlt can you merge master into your branch and then push again? I think your build will pass then

@AppVeyorBot
Copy link

Build cadquery 1.0.15 completed (commit c3e7fc698d by @jpmlt)

@codecov-io
Copy link

Codecov Report

Merging #251 into master will increase coverage by 0.12%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #251      +/-   ##
==========================================
+ Coverage   92.73%   92.85%   +0.12%     
==========================================
  Files          10       10              
  Lines        2174     2183       +9     
==========================================
+ Hits         2016     2027      +11     
+ Misses        158      156       -2
Impacted Files Coverage Δ
cadquery/cq.py 94.5% <100%> (+0.07%) ⬆️
cadquery/freecad_impl/shapes.py 91.38% <0%> (+0.23%) ⬆️
cadquery/freecad_impl/geom.py 92.47% <0%> (+0.31%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 980ca90...d40d8f4. Read the comment docs.

@dcowden
Copy link
Owner

dcowden commented Apr 9, 2018

@jmwright this looks ok with me. does it look ok to you?

@jmwright
Copy link
Collaborator

@dcowden I've tested it in our workbench and it looks great.

@jpmlt Thank you for the contribution!

@jmwright jmwright merged commit 213624b into dcowden:master Apr 10, 2018
@dcowden
Copy link
Owner

dcowden commented Apr 10, 2018

Thanks @jmwright for testing

@jpmlt thank you for jumping in! I know it probably took a lot of extra time to come up to speed on the whole git process-- but thanks for your willingness to do so!

Please feel freel to help us keep improving cadquery! We're seeing a lot of community help/adoption!

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants