-
Notifications
You must be signed in to change notification settings - Fork 56
Update sweep function in cq.py add test case and example #251
Conversation
❌ Build cadquery 1.0.8 failed (commit 227ee95323 by @jpmlt) |
@jpmlt thanks for the contribution! It looks like the python3 build failed due to missing conda package. PackagesNotFoundError: The following packages are not available from current channels:
I'll have a look at that when i get the chance. |
@jmwright you are more familiar with sweep-- what do you think about this PR? |
❌ Build cadquery 1.0.9 failed (commit cee6194c46 by @jpmlt) |
@dcowden I won't get to check it until tonight. I'm curious if it fixes #186 as well. @adam-urbanczyk Any thoughts on the missing FreeCAD Conda package? |
@dcowden @jmwright weird I triggered the appveyor build again to be sure, but still failes on the package not available. The funny thing is that I see it still being there: https://anaconda.org/freecad/freecad/files/modal/info/5ab4b7bce586bb11eae249c3 I will try to reproduce this problem on a local PC. |
❌ Build cadquery 1.0.12 failed (commit cee6194c46 by @jpmlt) |
❌ Build cadquery 1.0.13 failed (commit cee6194c46 by @jpmlt) |
Looks like I fixed it (Cf. #249). I think long term solution would be to make our own conda channel with all dependencies. |
@jpmlt can you merge master into your branch and then push again? I think your build will pass then |
✅ Build cadquery 1.0.15 completed (commit c3e7fc698d by @jpmlt) |
Codecov Report
@@ Coverage Diff @@
## master #251 +/- ##
==========================================
+ Coverage 92.73% 92.85% +0.12%
==========================================
Files 10 10
Lines 2174 2183 +9
==========================================
+ Hits 2016 2027 +11
+ Misses 158 156 -2
Continue to review full report at Codecov.
|
@jmwright this looks ok with me. does it look ok to you? |
update from last version dcowden#249
Update sweep function to allow to create only one solid swept along path with shape following the list of wires on the chain.
Update testcase by adding new test to use new functionality : testSweepAlongListOfWires
Add new example Ex034
JPM